[java-bridge] roki.kim(김경록) 미션 제출합니다.#1
Open
KimGyeongLock wants to merge 3 commits intoJapring-Study:mainfrom
Open
[java-bridge] roki.kim(김경록) 미션 제출합니다.#1KimGyeongLock wants to merge 3 commits intoJapring-Study:mainfrom
KimGyeongLock wants to merge 3 commits intoJapring-Study:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기능 요구사항을 따르기 위해
10줄 안에 함수를 자르고
파라미터를 3개를 초과하지 않게 제한하려다 보니
먼가 하면서도 어거지로 함수를 분리한게 아닌가라는 생각도 들었습니다..!
피드백 부탁드립니다.
그리고 하면서 머뭇거렸던 부분은 제시해준 move의 의도 였던 것 같습니다.
단 한줄로 함수를 구현하긴 했지만 이렇게 한다면 함수로 굳이 바꿀 필요가 있나 라는 생각이 들었습니다.