[java-baseball] roki.kim(김경록) 과제 제출합니다.#1
Open
KimGyeongLock wants to merge 1 commit intoJapring-Study:roki/java-baseballfrom
Open
[java-baseball] roki.kim(김경록) 과제 제출합니다.#1KimGyeongLock wants to merge 1 commit intoJapring-Study:roki/java-baseballfrom
KimGyeongLock wants to merge 1 commit intoJapring-Study:roki/java-baseballfrom
Conversation
yohanii
reviewed
Sep 24, 2024
Member
yohanii
left a comment
yohanii
left a comment
There was a problem hiding this comment.
고생 많으셨습니다!
개선할 점을 말씀드리면,
함수들이 다소 긴 느낌이 있어서, 작은 단위로 분리하면 가독성이 더 높아질 거 같아요!
파일을 분리해서, 클래스의 역할과 책임에 대해 생각해보시면 더 좋을 것 같습니다ㅎㅎ (저도 잘 못하지만..)
좋았던 점은
테스트를 여러 경우에 맞게 꼼꼼히 잘 작성하신 것 같고,
출력을 테스트하신 것도 좋았습니다!
또, validate를 잘 작성하신 것 같습니다! 👍👍
| } | ||
|
|
||
| //컴퓨터의 랜덤한 수 생성 함수 | ||
| public static int createRandomNumber() { |
Member
There was a problem hiding this comment.
for문이나, while문으로 작성하는 방법을 생각해보시면 더 좋을 것 같습니다!
| } | ||
|
|
||
| // 잘못된 입력 예외 처리 함수 | ||
| public static void validateNumber(int number) { |
|
|
||
| @Test | ||
| @DisplayName("checkNumber 메서드는 정확한 결과를 반환해야 한다") | ||
| void testCheckNumber() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
애매한 점
import java.util.Random;,import java.util.Scanner;사용해버림=> 그래서 기존의 test code가 작동되지 않음
=> 테스트 코드 따로 작성