Skip to content

chore(scaffold): Explicitly set minimum required Jahia version#631

Merged
GauBen merged 1 commit intomainfrom
chore-add-jahia-version-in-generated-package-json
Feb 6, 2026
Merged

chore(scaffold): Explicitly set minimum required Jahia version#631
GauBen merged 1 commit intomainfrom
chore-add-jahia-version-in-generated-package-json

Conversation

@baptistegrimaud
Copy link
Contributor

@baptistegrimaud baptistegrimaud commented Feb 6, 2026

Relates to Jahia/user-password-authentication#140.

Description

When generating the skeleton of a JavaScript Module project with https://www.npmjs.com/package/@jahia/create-module, define the mininum Jahia version required (required-version field) in the package.json.
This way, the version is explicit instead of relying on the default value (see https://github.com/Jahia/javascript-modules/blob/main/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/jshandler/JavascriptProtocolConnection.java#L242).

Tip

Documentation to guide the reviews: How to do a code review

@baptistegrimaud baptistegrimaud self-assigned this Feb 6, 2026
@baptistegrimaud baptistegrimaud added this to the javascript-modules 1.x milestone Feb 6, 2026
@baptistegrimaud baptistegrimaud changed the title chore: Add "required-version" field for generated projects chore(scaffold): Explicitly set minimum required Jahia version Feb 6, 2026
@baptistegrimaud baptistegrimaud marked this pull request as ready for review February 6, 2026 08:56
@baptistegrimaud baptistegrimaud requested a review from a team as a code owner February 6, 2026 08:56
Copilot AI review requested due to automatic review settings February 6, 2026 08:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an explicit required-version field to package.json templates in the JavaScript module scaffolding tool, setting the minimum Jahia version to "8.2.1.0" instead of relying on the default value.

Changes:

  • Added required-version field with value "8.2.1.0" to all three package.json templates (template-set, module, and hello-world)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
javascript-create-module/templates/template-set/package.json Added explicit minimum Jahia version requirement
javascript-create-module/templates/module/package.json Added explicit minimum Jahia version requirement
javascript-create-module/templates/hello-world/package.json Added explicit minimum Jahia version requirement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GauBen GauBen enabled auto-merge (squash) February 6, 2026 09:10
@GauBen GauBen disabled auto-merge February 6, 2026 09:10
@GauBen GauBen enabled auto-merge (squash) February 6, 2026 09:10
@GauBen GauBen merged commit 7dec14a into main Feb 6, 2026
20 checks passed
@GauBen GauBen deleted the chore-add-jahia-version-in-generated-package-json branch February 6, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants