Up to Laravel 11 + Fix table text color, some Links & Changelog ID's by sudwebdesign · Pull Request #50 · InvoicePlane/Wiki

sudwebdesign · 2025-05-08T17:33:44Z

Checklist

My code follows the code formatting guidelines.
I have tested my changes locally.
I selected the appropriate branch for this PR.
I have rebased my changes on top of the selected branch.
I included relevant documentation updates if necessary.
I have an accompanying issue ID for this pull request.

Description

Upgrade to Laravel 11
Update node dependencies
Work on PHP 8.2
Some link fix (and add url() for good path if is in (or not) sub directory)

Note for htaccess:

For work locally, I commented this in my `.htaccess` file to fix: `Invalid command 'ExpiresActive', perhaps misspelled or defined by a module not included in the server configuration`

# Expires header
#<IfModule mod_expires.c>
#    ExpiresActive On
#    ExpiresByType text/css "access plus 1 month"
#    ExpiresByType application/javascript "access plus 1 month"
#    ExpiresByType application/x-javascript "access plus 1 month"
#    ExpiresByType image/gif "access plus 1 month"
#    ExpiresByType image/jpeg "access plus 1 month"
#    ExpiresByType image/png "access plus 1 month"
#    ExpiresByType image/x-icon "access plus 1 year"
#</IfModule>
# Deflate Compression by MimeType
#<IfModule mod_deflate.c>
#    <FilesMatch "\.(js|jpg|jpeg|gif|png|css)$">
#        ExpiresActive on
#        ExpiresDefault "access plus 1 month"
#        SetOutputFilter DEFLATE
#    </FilesMatch>
#</IfModule>

Related Issue(s)

None

Motivation and Context

At first time, just for correct text table color but not worked locally. after some research & some refactoring, It's work with Laravel 11.

Big thank to rector.

Issue Type (Check one or more)

Bugfix (Links, table text color & hide sidebar X on large screen)
Improvement of an existing feature (Laravel v5 To v11)
New feature (devlink, rector)

Screenshots (Change-log links)

composer install or upgrade vendor/bin/rector process --dry-run vendor/bin/rector process https://dev.to/nasrulhazim/automating-code-refactoring-in-laravel-with-rector-2151

Fix Target class [WikiController] does not exist.

npm run build (Ok) --- Note node-sass v9.0.0 (deprecated) popper.js v1.16.1 (deprecated) --- npm audit report bootstrap 4.0.0 - 4.6.2 Severity: moderate Bootstrap Cross-Site Scripting (XSS) vulnerability - GHSA-vc8w-jr9v-vj7f fix available via `npm audit fix --force` Will install bootstrap@5.3.6, which is a breaking change node_modules/bootstrap postcss <=8.4.30 Severity: moderate Regular Expression Denial of Service in postcss - GHSA-566m-qj78-rww5 PostCSS line return parsing error - GHSA-7fh5-64p2-3v2j fix available via `npm audit fix --force` Will install autoprefixer@10.4.21, which is a breaking change node_modules/autoprefixer/node_modules/postcss node_modules/grunt-postcss/node_modules/postcss autoprefixer 1.0.20131222 - 9.8.8 Depends on vulnerable versions of postcss node_modules/autoprefixer grunt-postcss * Depends on vulnerable versions of postcss node_modules/grunt-postcss 4 moderate severity vulnerabilities

See https://wiki.invoiceplane.com/en/1.6/settings/general#general

For headlineLink() & $article_pagination var

Same for all (don't reload the page on headlineLink (#)

C + commit ID PR + Pull Request ID IP + (old?) ID (search in gh & archive)

Restore before 6e13d1b

sudwebdesign · 2025-05-08T17:37:19Z

resources/assets/sass/_variables.scss

 $table-dark-border-color:     lighten($gray-900, 7.5%) !default;
 $table-dark-color:            $body-bg !default;
-$table-color:                 $table-dark-color;
+$table-color:                 $body-color;


This make text color to black in tables

sudwebdesign · 2025-05-08T17:40:21Z

resources/views/includes/article_pagination.blade.php

        $btn_class = ($article_pagination['previous']['type'] == 'section' ? 'btn-primary' : 'btn-secondary');
        echo '
-        <a href="' . $article_pagination['previous']['url'] . '" class="btn ' . $btn_class . ' pull-left">
+        <a href="' . url($article_pagination['previous']['url']) . '" class="btn ' . $btn_class . ' pull-left">


Make an absolute url in relation with APP_URL from .env

sudwebdesign · 2025-05-08T17:41:49Z

resources/views/includes/sidebar.blade.php

    <div class="sidebar-top">
        <a href="{{ config('app.url')  }}">@lang('global.wiki')</a>
-        <a href="#" class="sidebar-toggle pull-right"><i class="fa fa-close"></i></a>
+        <a href="#" class="sidebar-toggle pull-right d-lg-none d-xl-none"><i class="fa fa-close"></i></a>


Hide sidebar X on large screen

sudwebdesign · 2025-05-08T18:08:41Z

After run php artisan optimize in terminal

I encountered an Internal server error named Call to undefined method Closure::__set_state()

I solved by deletion of bootstrap/cache/routes-v7.php file & it run like a charm.

sudwebdesign added 11 commits May 8, 2025 15:08

[wip] Up to PHP 8 + Laravel 11 + refacto by rector

3d2e50c

composer install or upgrade vendor/bin/rector process --dry-run vendor/bin/rector process https://dev.to/nasrulhazim/automating-code-refactoring-in-laravel-with-rector-2151

[Up Laravel 5 to 11] New routes grammar to find Wiki Controller.

3c67d89

Fix Target class [WikiController] does not exist.

[scss] Fix table (text) color is pratically invisible

d8e7c34

See https://wiki.invoiceplane.com/en/1.6/settings/general#general

Clean some not necessary spaces

4bb9309

Add some url() to dev locally easily. Work in subdir (or not)

2ea6111

For headlineLink() & $article_pagination var

Fix bad invoicegroups urls [it's invoice-groups]

3d573cd

Fix duplicate content user_accounts urls [it's user-accounts]

98825a9

Same for all (don't reload the page on headlineLink (#)

Hide cross to close sidebar on large screen (it's ineffective)

3e98349

[idea for changelog]C, PR & IP opt for IP::devLink($issue_id)

e0e13fc

C + commit ID PR + Pull Request ID IP + (old?) ID (search in gh & archive)

Changelog: Good IP issue numbers from v1.0.0 to v1.5.9

72f13e8

Restore before 6e13d1b

sudwebdesign commented May 8, 2025

View reviewed changes

naui95 self-requested a review August 5, 2025 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Up to Laravel 11 + Fix table text color, some Links & Changelog ID's#50

Up to Laravel 11 + Fix table text color, some Links & Changelog ID's#50
sudwebdesign wants to merge 11 commits intoInvoicePlane:masterfrom
sudwebdesign:master

sudwebdesign commented May 8, 2025 •

edited

Loading

Uh oh!

sudwebdesign May 8, 2025

Uh oh!

sudwebdesign May 8, 2025

Uh oh!

sudwebdesign May 8, 2025

Uh oh!

sudwebdesign commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sudwebdesign commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description

Note for htaccess:

Related Issue(s)

Motivation and Context

Issue Type (Check one or more)

Screenshots (Change-log links)

Uh oh!

sudwebdesign May 8, 2025

Choose a reason for hiding this comment

Uh oh!

sudwebdesign May 8, 2025

Choose a reason for hiding this comment

Uh oh!

sudwebdesign May 8, 2025

Choose a reason for hiding this comment

Uh oh!

sudwebdesign commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sudwebdesign commented May 8, 2025 •

edited

Loading