Windows Python CMake configuration fixes#5854
Open
thewtex wants to merge 2 commits intoInsightSoftwareConsortium:releasefrom
Open
Windows Python CMake configuration fixes#5854thewtex wants to merge 2 commits intoInsightSoftwareConsortium:releasefrom
thewtex wants to merge 2 commits intoInsightSoftwareConsortium:releasefrom
Conversation
When ITK_USE_PYTHON_LIMITED_API is ON (Python >= 3.11), the second find_package(Python3) call only requested Development.SABIModule, never creating the Python3::Module target. ITKCommon unconditionally referenced Python3::Module, causing a CMake generate-time error. - Always request Development.Module alongside Development.SABIModule so the Python3::Module target is created regardless of limited API setting - Select Python3::SABIModule or Python3::Module in ITKCommon based on ITK_USE_PYTHON_LIMITED_API for architecturally correct linking - Extend Python3_ROOT_DIR inference to Windows (was Unix/Apple only) so FindPython3 locates the correct installation from virtualenvs
On Windows, we need to specify the link directory for python311.lib. This is for building the ITKPythonPackage after recent target-based build system and CMake find python changes.
github-actions
bot
added
type:Infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes for the CMake Python configuration to address the Windows ITKPythonPackage build.