Correct the logic for passing over CPU/RECURSIVE devices#557
Merged
abouteiller merged 2 commits intoICLDisco:masterfrom Sep 6, 2023
Merged
Correct the logic for passing over CPU/RECURSIVE devices#557abouteiller merged 2 commits intoICLDisco:masterfrom
abouteiller merged 2 commits intoICLDisco:masterfrom
Conversation
abouteiller
added
bug
devreal
reviewed
Jun 21, 2023
recursive device is not built-in Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
by index, without comparing with DEV_RECURSIVE Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
abouteiller
force-pushed
the
bugfix/recursive-off-devindex
branch
from
c92b040 to
b8f5899
Compare
Contributor
Author
|
Contributor
Author
|
bug is actually due to #544 |
Contributor
|
Not sure I understand how the bug can be due to a yet-to-be merged PR ? |
Contributor
Author
|
wrong number, it's the async one. |
Contributor
Author
|
this needs reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the logic for passing over CPU/RECURSIVE devices when the recursive device is not built-in
We use the dev->type instead of the dev_index to identify the devices.