Open
Conversation
therault
force-pushed
the
gpu_pingpong_test
branch
from
e329147 to
49b0fd2
Compare
bosilca
approved these changes
Jun 14, 2023
abouteiller
approved these changes
Jun 16, 2023
therault
force-pushed
the
gpu_pingpong_test
branch
16 times, most recently
from
2cdb527 to
4222191
Compare
Contributor
Author
|
I'm a bit lost with CI here... Another pair of eyes would help. To summarize what I observe:
To conclude, I have no idea why |
therault
force-pushed
the
gpu_pingpong_test
branch
7 times, most recently
from
1ffaec0 to
db3ad7d
Compare
bosilca
force-pushed
the
gpu_pingpong_test
branch
from
b9f4741 to
db3ad7d
Compare
therault
force-pushed
the
gpu_pingpong_test
branch
from
a3f8803 to
49f7d56
Compare
abouteiller
reviewed
Aug 9, 2023
abouteiller
reviewed
Aug 9, 2023
| #include "parsec/data_dist/matrix/two_dim_rectangle_cyclic.h" | ||
| #include "parsec/interfaces/dtd/insert_function_internal.h" | ||
| #include "tests/tests_data.h" | ||
| #include "parsec/mca/device/cuda/device_cuda_internal.h" |
Contributor
There was a problem hiding this comment.
why do we need this, this is internal and should not spillover into user code.
Contributor
|
please rebase and reassess the changes to the CI part (not clear they are still needed). |
make a token pass from CPU to each GPU, and back, a few times, to check a possible bug found by @devreal. Part of the DTD interface was not fully ported to HIP Enable (cuda|hip)_pingpong test in CI Add a PTG GPU pingpong test to compare with the behavior in DTD -- Work in progress Tests need to import the appropriate GPU-specific header file, as insert_function_internal.h doesn't do it for them anymore Enable PTG test over CUDA Fix errors in data distribution initialization and some DAG errors in the PTG of the GPU pingpong test Rename files and directories to match the new status of tests (tests/runtime/cuda is renamed tests/runtime/gpu and the pingpong tests are named to specify the API and not a particular device name, since they should work on both GPU types) Only define the pingpong tests if a suitable compiler is found for the kernels Do a ping-pong-pong test instead of ping-pong, to see how dependencies are tracked on GPU-to-GPU task dependency Fix the checks of the pingpong test, and add it in the Testings.cmake PTG ping-pong test: in order to guide the selection of the best device, the advised data needs to flow from a CPU task, not directly from memory. Trying to introduce the gpu_nvidia runner in the CI matrix Add ROCm, create one github_runner-[device].yaml file per device; remove debugging info from CMakeLists.txt Add some infrastructure to make sure CI does the device tests where it should, and issue an error if things cannot be tested (e.g. because the GPUs are down or the compiler/spack is broken) Trying to work around the xml2 issue with mesa. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> Integrate the gpu_amd/release in the test suite Add support to rocm-smi in check_nb_devices.sh Conditional CMake command that depends upon the github runner loaded to prepare for testing
therault
force-pushed
the
gpu_pingpong_test
branch
from
e6b4966 to
c644262
Compare
…e if we install binutils+headers?
therault
force-pushed
the
gpu_pingpong_test
branch
from
b7055c4 to
36f7822
Compare
Contributor
Author
|
Split this PR in two: one for the tester itself and another for the CI/runners |
Contributor
|
There has not been a lot of progress on this, and I think we can autogenerate (hipify) the hip testers, lets postpone to 4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a simple test that makes data be updated on CPU and on GPUs alternatively.
As part of the test, I found out that HIP was not ported over DTD, and this ports HIP over DTD. It also provides a first test for HIP.