Support arguments (canonicalQueryString) and UNSIGNED-PAYLOAD#2
Open
smiba wants to merge 11 commits intoHubSpot:masterfrom
Open
Support arguments (canonicalQueryString) and UNSIGNED-PAYLOAD#2smiba wants to merge 11 commits intoHubSpot:masterfrom
smiba wants to merge 11 commits intoHubSpot:masterfrom
Conversation
Author
|
0b08243 fixes the empty QueryStrings :) Last thing to do is be more smart about routing requests like ?delete (bulk removals), but this is gonna require a fair bit more work, possibly outside of this library |
Member
|
Hey @smiba , I'm not wure when I'll have a chance to test this in our own infra before merging. I take it you are able to use your own fork for now and aren't blocked here? Thanks for the contribution by the way! |
Author
|
Yes! We're using this and it's been working fine, I specifically made these contributions to the code for our infra (Even made a little write-up which includes using this library: https://medium.com/@PurpleDug/woof-tech-routing-s3-endpoints-and-doing-a-live-migration-on-a-production-environment-as-a-treat-8fa2bbd6784e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly messy PR, sorry about that
These changes provide
ngx.var.request_bodyis empty (might happen when it does not fit in nginx body buffer)To do: