Try to cleanup vendor type-id messaging (Monkooky)#3
Merged
Implojin merged 1 commit intoHellmonk:testfrom Aug 13, 2025
Merged
Conversation
Collaborator
Author
|
ope I inverted the logic, one sec |
Previously, vendor acquirements of items with type-ids would output a repetitive "You learned that your 3 scrolls of silence are actually 3 scrolls of silence." message to the log. Here we run seen_item() immediately upon acquiring a vendor item, with squelched type-id messaging, to hopefully handle these post- purchase messages for vendor items with type-id a little more gracefully.
Implojin
force-pushed
the
vendor-message
branch
from
a7e8ad1 to
4d9b081
Compare
Collaborator
Author
|
Ok that should be good, for some token level of good anyway (would prefer not to be passing around a bunch of bools but I'm assuming we don't want to re-add more ISFLAG nonsense so here we are (?)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, vendor acquirements of items with type-ids would output a repetitive "You learned that your 3 scrolls of silence are actually 3 scrolls of silence." message to the log.
Here we run seen_item() immediately upon acquiring a vendor item, with squelched type-id messaging, to hopefully handle these post- purchase messages for vendor items with type-id a little more gracefully.