Add nightly live Discord sync e2e validation

[Makisuo]

Summary

• add live Discord test env loader with explicit fallback: DISCORD_SYNC_TEST_BOT_TOKEN -> DISCORD_BOT_TOKEN
• add live e2e suite for Hazel->Discord and Discord->Hazel sync lifecycle checks
• add nightly GitHub Actions workflow for live sandbox guild/channel validation
• add test:sync:live command

Notes

• This PR is intentionally stacked on Add deterministic Discord↔Hazel sync regression suite #274 to keep live validation isolated from deterministic PR-blocking tests.

Validation

• bun run --cwd apps/backend test:sync:live (skips locally when live env vars are not configured)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hazel-docs	Ready	Preview, Comment	Feb 14, 2026 10:56pm

[claude]

Claude finished @Makisuo's task —— View job

---

PR Review Complete ✅

Reviewing PR #275: "Add nightly live Discord sync e2e validation"

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze GitHub Actions workflow file
• Review test configuration and implementation
• Check package.json changes
• Evaluate security considerations
• Provide comprehensive feedback

---

Code Review Feedback

✅ Strengths

Well-structured test architecture:

• Clean separation between config loading (chat-sync-live-test-config.ts) and test implementation
• Proper conditional test execution with describe.skip when environment not configured
• Comprehensive test coverage for both sync directions (Hazel→Discord and Discord→Hazel)
• Good use of test harnesses and proper cleanup in afterAll

Security best practices:

• Excellent token fallback strategy: DISCORD_SYNC_TEST_BOT_TOKEN → DISCORD_BOT_TOKEN
• Proper secret handling in GitHub Actions workflow
• No hardcoded credentials or sensitive data

Effect-TS integration:

• Follows repository patterns with proper Effect usage in chat-sync-live-test-config.ts:17-44
• Consistent error handling and layer composition in test setup
• Good use of Effect.scoped for resource management

🔧 Areas for Improvement

1. Type Safety Enhancement
In chat-sync-live-test-config.ts:21-23, consider stronger typing for the token fallback:

// Current:
const botToken =
    readNonEmpty("DISCORD_SYNC_TEST_BOT_TOKEN") ??
    readNonEmpty("DISCORD_BOT_TOKEN")

// Suggested: Add explicit type annotation for clarity
const botToken: string | undefined =
    readNonEmpty("DISCORD_SYNC_TEST_BOT_TOKEN") ??
    readNonEmpty("DISCORD_BOT_TOKEN")

2. Test Reliability Concerns
In chat-sync-live-discord.e2e.test.ts:247-249, the channel selection logic could be clearer:

// This line could benefit from better documentation
const activeChannelId = (liveConfig.channelId2 ?? liveConfig.channelId) as ExternalChannelId

3. Error Handling in Cleanup
The cleanup logic in afterAll (lines 256-282) properly handles errors with Effect.catchAll(() => Effect.void), but consider logging cleanup failures for debugging:

// Consider adding diagnostic logging
Effect.catchAll((error) => {
    recordChatSyncDiagnostic({ /* cleanup error details */ })
    return Effect.void
})

4. Test Timeout Consistency
Mixed timeout values across tests (180s, 240s, 60s) - consider standardizing or documenting the rationale for different timeouts.

📋 Code Quality Assessment

• Architecture: Excellent separation of concerns and clean abstractions
• Testing: Comprehensive e2e coverage with proper setup/teardown
• Error Handling: Good defensive programming with fallbacks and cleanup
• Documentation: Clear intent through descriptive test names and diagnostic recording

🚀 GitHub Actions Workflow Review

Positive aspects:

• Appropriate timeout (45 minutes) for live testing
• Smart caching strategy for Bun dependencies
• Proper artifact collection on failure with scoped naming
• Manual trigger via workflow_dispatch for debugging

Suggestions:

• Consider adding a step to validate environment variables before running tests
• The diagnostic directory path could be configurable via environment variable

🔒 Security Assessment

• ✅ No secrets leaked in code
• ✅ Proper use of GitHub secrets
• ✅ Fallback token strategy well-implemented
• ✅ Cleanup logic prevents data accumulation

📈 Performance Considerations

• Test timeouts are appropriately generous for live API calls
• Proper use of beforeEach reset for test isolation
• Efficient database operations using batch inserts where possible

---

Overall Assessment: Excellent addition 🎉

This PR demonstrates high-quality engineering with proper testing patterns, security considerations, and integration with the existing Effect-TS architecture. The live validation approach adds significant value for ensuring Discord integration reliability.

Recommendation: Approve with minor suggested improvements

---

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
❌ Deployment failed View logs	hazel-app	ee4697e	Feb 14 2026, 10:57 PM