Draft
Conversation
Contributor
|
i miss documentation and a variable in -> since the API call need the key it should be mandatory at start maybe as parameter for start additionaly I would allow the user to change the interval and the url of the service (in case they change again the api) |
Member
|
@roeeyn apologies for the delay in getting to this - there are some errors from the docstrings linter that would need to be taken care of before this can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've always enjoyed the dynamism of having a fresh background with every Hammerspoon config reload. I have used both the UnsplashRandom and UnsplashZ Spoons in the past, but recently, they've started to exhibit issues. The core of this problem stems from Unsplash's decision to deprecate the source endpoint, which both of these Spoons heavily relied upon.
In light of this, I took the initiative to develop a new Spoon that taps into the modern Unsplash API. The primary distinction with this approach is the necessity of an API key, a measure implemented by Unsplash to safeguard against misuse. However, I am currently in the process of finalizing the best practices for documenting these instructions.
I sincerely appreciate any feedback you might have and look forward to collaborating with the community to make this Spoon the best it can be. 😄