Skip to content

Conversation

@hd1ex
Copy link
Collaborator

@hd1ex hd1ex commented Feb 14, 2025

No description provided.

Copy link

@pablo-schmeiser pablo-schmeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could already upgrade to django 6.0.1 (which is the latest release, although some of our other packages don't support it yet - e.g. django-stubs is still missing stubs for APIs from django 6)
For this we should however consider the following backward issues :

  • BaseDatabaseSchemaEditor and PostgreSQL backends no longer use CASCADE when dropping a column. -> Is this a problem with migrations? Or is this still fine (couldn't we just regenerate all migrations)? see here
  • We should remove compatibility for Python < 3.12 see here
  • Should we remove usage of the ordering keyword? Why: see here

Aside from this discussion, we should bump the rest to their most up-to-date versions (see requested changes). This has not been tested yet, but the release notes suggest all of this should be fine.

'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.14',

'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.13',

'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.9',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.12',

'python-dateutil==2.8.2',
'requests==2.31.0',
'Authlib==1.4.1',
'Django==5.2.3',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Django==5.2.3',
'Django==5.2.11',

'holidays==0.75',
'icalendar==6.3.1',
'Pillow==11.2.1',
'psycopg2-binary==2.9.10',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'psycopg2-binary==2.9.10',
'psycopg[binary]==3.3.3',

docs = [
'mkdocs==1.4.2',
'mkdocs-material==9.0.11',
'django-stubs==4.2.7',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'django-stubs==4.2.7',
'django-stubs==5.2.9',

'mkdocs==1.4.2',
'mkdocs-material==9.0.11',
'django-stubs==4.2.7',
'types-python-dateutil==2.8.19.14',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'types-python-dateutil==2.8.19.14',
'types-python-dateutil==2.9.0.20260124',

'mkdocs-material==9.0.11',
'django-stubs==4.2.7',
'types-python-dateutil==2.8.19.14',
'types-requests==2.31.0.10',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'types-requests==2.31.0.10',
'types-requests==2.32.4.20260107',

'django-stubs==4.2.7',
'types-python-dateutil==2.8.19.14',
'types-requests==2.31.0.10',
'mypy==1.8.0',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'mypy==1.8.0',
'mypy==1.19.1',

'mypy==1.8.0',
]

docs = ['mkdocs==1.4.2', 'mkdocs-material==9.0.11']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docs = ['mkdocs==1.4.2', 'mkdocs-material==9.0.11']
docs = ['mkdocs==1.6.1', 'mkdocs-material==9.7.1']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants