Shift Complete Item Functionality to Task Dropdown Menu#128
Open
tjfwalker wants to merge 10 commits intoGuildCrafts:masterfrom
Open
Shift Complete Item Functionality to Task Dropdown Menu#128tjfwalker wants to merge 10 commits intoGuildCrafts:masterfrom
tjfwalker wants to merge 10 commits intoGuildCrafts:masterfrom
Conversation
- html structure - styling
Connect item menu element to event listener
Abide by the canonical code style.
Include need no name
tjfwalker
changed the title
between UI components —from item bullet point to 'Complete' li in the item menu
tjfwalker
force-pushed
the
feature/complete-via-menu
branch
from
e055049 to
90e2ca6
Compare
tjfwalker
changed the title
Contributor
Author
|
@jrob8577, @GeneralMeow, @sdweber422 ready for review. |
tjfwalker
force-pushed
the
feature/complete-via-menu
branch
from
27456b1 to
10e7059
Compare
Contributor
Author
|
@jrob8577
|
jrobcodes
suggested changes
Dec 22, 2016
Contributor
jrobcodes
left a comment
jrobcodes
left a comment
There was a problem hiding this comment.
@shakalee14 @tjfwalker One comment
public/javascripts/items.js
Outdated
| const completedClicked = event => { | ||
| const element = $( event.target ) | ||
| const id = element.data( 'id' ) | ||
| const id = element.parent().data().id |
Contributor
There was a problem hiding this comment.
I think this needs to be (docs)
const id = element.parent().data( 'id' )
Contributor
There was a problem hiding this comment.
Also, why doesn't the element just have the id for itself, given that it's the target of this event? I just don't like hanging our code on the notion that the html structure here won't change.
Conciliate the supreme Jrob =]
tjfwalker
force-pushed
the
feature/complete-via-menu
branch
from
10bd1b1 to
a627b1c
Compare
Contributor
Author
|
@jrob8577 your most recent review has been acted upon. Please rereview. |
jrobcodes
approved these changes
Dec 22, 2016
jrobcodes
suggested changes
Dec 22, 2016
| $( '.item__edit-description' ).keypress( descriptionEdited ) | ||
| $( '.item__description > span' ).click( clickToUpdate( 'item__description' )) | ||
| $( '.item__toggle' ).click( completedClicked ) | ||
| $( '.item__menu ul li:first-child' ).click( completedClicked ) |
Contributor
There was a problem hiding this comment.
Please use explicit class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #125