Improve handling of not found exception from GetViewForHwnd() and re-add TogglePin functions#14
Open
sliddington wants to merge 5 commits intoGrabacr07:masterfrom
Open
Improve handling of not found exception from GetViewForHwnd() and re-add TogglePin functions#14sliddington wants to merge 5 commits intoGrabacr07:masterfrom
sliddington wants to merge 5 commits intoGrabacr07:masterfrom
Conversation
sliddington
changed the title
sliddington
changed the title
ericnewton76
left a comment
ericnewton76
left a comment
There was a problem hiding this comment.
Thanks for your work on this pull request. I added a few thoughts to the code.
| ComObjects.ApplicationViewCollection.GetViewForHwnd(hWnd, out view); | ||
| return view; | ||
| } | ||
| catch (System.Runtime.InteropServices.COMException ex) when (ex.Match(HResult.TYPE_E_ELEMENTNOTFOUND)) |
There was a problem hiding this comment.
might consider not using C#6.0 specific features yet for more broad compilation support of the library itself
|
|
||
| if (view == null) | ||
| { | ||
| throw new ArgumentException(nameof(hWnd)); |
There was a problem hiding this comment.
this should message out why its an argument exception, and probably not use C#6.0 for more broad compilation possibility:
throw new ArgumentException("hWnd specified not found","hWnd");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch not found exception from GetViewForHwnd() to return null or throw ArgumentException