This repository was archived by the owner on Jan 15, 2021. It is now read-only.
Addressing synchronization issues in InMemoryStorage class with the f…#95
Open
mike-kaufman wants to merge 31 commits intoGlimpse:devfrom
Open
Addressing synchronization issues in InMemoryStorage class with the f…#95mike-kaufman wants to merge 31 commits intoGlimpse:devfrom
mike-kaufman wants to merge 31 commits intoGlimpse:devfrom
Conversation
- also remove incorrect `-beta` versions for ASP.NET packages from `project.json` file
…ices which is removed from HttpContext
Getting the broker through RequestServices instead of ApplicationServ…
…rwriting with setcontent
Appending html to PostContent rather than set
Initial commit of SystemWeb project structure
…it was there was no way of manual controlling things if you wanted to
…e rest of the system named
…ollowing changes:
- added ReaderWriterLockSlim to control access to InMemoryStorage's dictionary & list that track individual RequestInfo instances
- added ReaderWriterLockSlim to control access to each individual RequestAccess
- removed RequestInfo's "Messages" accessor, and replaced it with a SnapshotMessages() method that will make a copy of
the current set of messages. This is to avoid "collection has been modified" exceptions where the underlying set of messages is
modified while a previous call is iterating over the list.
- Made RequestIndices instances immutable.
- added a bunch of asserts to validate assumptions about locking of resources.
- added a test that was triggering the reported "collection modified" exceptions.
Author
|
@avanderhoorn, @nikmd23 - this is waiting on your review/feedback. Let me know if you have questions/comments/suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing synchronization issues reported in Issue #82 in InMemoryStorage class with the following changes:
Please let me know if there's questions or feedback.