Added dark mode support to index.html#646
Open
danielwcarey wants to merge 2 commits intoGideonZ:masterfrom
Open
Added dark mode support to index.html#646danielwcarey wants to merge 2 commits intoGideonZ:masterfrom
danielwcarey wants to merge 2 commits intoGideonZ:masterfrom
Conversation
…s not change text color when theme switched.
danielwcarey
force-pushed
the
addDarkMode
branch
from
988a750 to
0d78e44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the index.html to default to system's selected light/dark mode selection and updated the banner to include toggle icons between light and dark. If the browser doesn't support theming, there should be no visible change, and the toggle icons won't appear.
I tried to make minimal edits but also provide something that may enable more themes if others are so inclined to pursue.
For reference, this is the snapshot of primary theme and then some screenshots of the dark theme
when applied to several pages: