feat: [CHA-1584] - Predefined filters support#1675
Conversation
Signed-off-by: Lennart Kuijs <mail@lennartkuijs.nl>
|
Size Change: +1.15 kB (+0.32%) Total Size: 360 kB
|
totalimmersion
requested review from
MartinCupela,
arnautov-anton,
isekovanic,
khushal87,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
oliverlaz
changed the title
| * Values to interpolate into the predefined filter template placeholders. | ||
| * Only used when predefined_filter is provided. | ||
| */ | ||
| filter_values?: Record<string, unknown>; |
There was a problem hiding this comment.
Keys in this object will need to correspond to some specific entity field names or it can really be any string?
There was a problem hiding this comment.
@totalimmersion Could you give an example of interpolation, please?
There was a problem hiding this comment.
can be any string
There was a problem hiding this comment.
|
|
||
| export type PredefinedFilterOperation = 'QueryChannels'; | ||
|
|
||
| export type PredefinedFilterSortParam = { |
There was a problem hiding this comment.
@totalimmersion there was a discussion btw @kanat and @arnautov-anton regarding type sort field. Is this change maybe related to the general change in sort fields? Would this PR, where type field is introduced be relevant for your PR?
There was a problem hiding this comment.
not sure about that discussion, this pr follows current practices
| `${this.baseURL}/predefined_filters`, | ||
| { | ||
| ...paginationOptions, | ||
| ...(sort ? { sort: JSON.stringify(sort) } : {}), |
There was a problem hiding this comment.
@totalimmersion Why do we convert the object into string? I see in types.ts the following declarations implying and usually objects are not stringified in other API calls in other methods:
export type PredefinedFilterSort = SortParam[];
export type ListPredefinedFiltersOptions = Pager & {
sort?: PredefinedFilterSort;
};
There was a problem hiding this comment.
because it's a GET request
Co-authored-by: MartinCupela <32706194+MartinCupela@users.noreply.github.com>
Co-authored-by: MartinCupela <32706194+MartinCupela@users.noreply.github.com>
## [9.29.0](v9.28.0...v9.29.0) (2026-01-20) ### Bug Fixes * escape strings interpolated into regular expressions ([#1669](#1669)) ([32705e1](32705e1)) ### Features * [CHA-1584] - Predefined filters support ([#1675](#1675)) ([cb6d2d1](cb6d2d1)) * add Future Channel Bans support [CHA-1696] ([#1677](#1677)) ([2effaba](2effaba))
|
🎉 This PR is included in version 9.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
No description provided.