-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Fixes #13885] Support for COG Remote Layers #13887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sijandh35, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Cloud Optimized GeoTIFF (COG) remote layers within GeoNode. It provides a dedicated handler that can validate COG URLs, extract essential geospatial metadata like CRS and bounding box using GDAL, and correctly register these remote resources. This enhancement significantly expands GeoNode's capabilities for handling and integrating external raster data sources efficiently. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for remote Cloud Optimized GeoTIFF (COG) layers by adding a new RemoteCOGResourceHandler. The implementation is well-structured, correctly validating remote COG files by checking for HTTP Range Request support and using GDAL's /vsicurl/ virtual filesystem to extract metadata. The handler also properly calculates the bounding box for rotated rasters. The changes are accompanied by a good set of unit tests. I have identified one critical issue in the new handler that could lead to an unhandled exception.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13887 +/- ##
==========================================
+ Coverage 74.07% 74.22% +0.14%
==========================================
Files 932 946 +14
Lines 55720 56609 +889
Branches 7522 7669 +147
==========================================
+ Hits 41277 42016 +739
- Misses 12794 12901 +107
- Partials 1649 1692 +43 🚀 New features to boost your workflow:
|
Fixes #13885
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.