fix: Add an error counter to stop workflow if one step failed#231
Open
RomainBaville wants to merge 6 commits intomainfrom
Open
fix: Add an error counter to stop workflow if one step failed#231RomainBaville wants to merge 6 commits intomainfrom
RomainBaville wants to merge 6 commits intomainfrom
Conversation
RomainBaville
added
type: bug
test-geos-integration
paloma-martinez
approved these changes
Feb 26, 2026
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
Looks good to me :)
Just a few typos to fix
| else: | ||
| self.logger.info( f"{ result }." ) | ||
|
|
||
| # Keep number of warnings logged during the filter application and reset the warnings count in case the filter is apply again. |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Keep number of warnings logged during the filter application and reset the warnings count in case the filter is apply again. | |
| # Keep number of warnings logged during the filter application and reset the warnings count in case the filter is applied again. |
Collaborator
There was a problem hiding this comment.
Please correct it in all the files :)
| """Compute Geomechanical properties on input surface. | ||
|
|
||
| Raises: | ||
| TypeError: Error With the type of the input mesh. |
Collaborator
There was a problem hiding this comment.
Suggested change
| TypeError: Error With the type of the input mesh. | |
| TypeError: Error with the type of the input mesh. |
| npt.NDArray[np.float64]: Vector of new coordinates of the attribute. | ||
|
|
||
| Raises: | ||
| ValueError: Error with the shape of attrArray or the computation of the attribute coordinate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| ValueError: Error with the shape of attrArray or the computation of the attribute coordinate. | |
| ValueError: Error with the shape of attrArray or the computation of the attribute coordinates. |
|
|
||
| if not np.any( np.isfinite( attrXYZ ) ): | ||
| self.logger.error( "Attribute new coordinate calculation failed." ) | ||
| raise ValueError( "Attribute new coordinate calculation failed." ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise ValueError( "Attribute new coordinate calculation failed." ) | |
| raise ValueError( "Attribute new coordinates calculation failed." ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a ParaView plugin of geos-pv the error managment is as follow:
If a plugin "a" calls another plugin "b", even if an error is raised during the call of the plugin "b", the plugin "a" raises no error and doesn't stop.
This PR features the renaming of the handler "CountWarningsHandler" to "CountVerbosityHandler". It will now count warnings, errors and higher verbosity as well (e.g. critical error).
Using this counter, the plugin "b" will save the number of error logged and the plugin "a" can get it at the end of the application of the plugin "b".
This PR close #233