feat: Solution scaling for thermal single phase#3979
Open
frankfeifan wants to merge 5 commits intodevelopfrom
Open
feat: Solution scaling for thermal single phase#3979frankfeifan wants to merge 5 commits intodevelopfrom
frankfeifan wants to merge 5 commits intodevelopfrom
Conversation
frankfeifan
requested review from
OmarDuran,
dkachuma,
rrsettgast and
tjb-ltk
as code owners
tjb-ltk
reviewed
Feb 23, 2026
Contributor
There was a problem hiding this comment.
give the 1 and 2 a name... varOffset or something descriptor
tjb-ltk
approved these changes
Feb 23, 2026
Contributor
tjb-ltk
left a comment
tjb-ltk
left a comment
There was a problem hiding this comment.
Good addition and cleanup of single/compositional well scaling paramerters
frankfeifan
added
flag: ready for review
ci: run integrated tests
frankfeifan
commented
Feb 25, 2026
| dofManager.addVectorToField( localSolution, | ||
| wellElementDofName(), | ||
| well::connectionRate::key(), | ||
| scalingFactor, |
Contributor
Author
There was a problem hiding this comment.
Not sure which scaling factor should be used here for the connectionRate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to enable scaling factor for temperature in the thermal single-phase flow and well models. Following changes are made:
scalingFactoroutput byscalingForSystemSolutionis a global min of pressure and temperature scaling factors