Add Triple Point Shock Problem as Euler Application#310
Open
DamynChipman wants to merge 7 commits intoForestClaw:developfrom
Open
Add Triple Point Shock Problem as Euler Application#310DamynChipman wants to merge 7 commits intoForestClaw:developfrom
DamynChipman wants to merge 7 commits intoForestClaw:developfrom
Conversation
Author
|
I failed to add the regression test files, I added them in the latest commit. |
Author
|
The only test that fails is the CMake build on MacOS. It fails when running the regression test for I'll remove output for the regression tests to see if that fixes it. |
Author
|
Merged recent |
Author
|
Ready to merge! |
Member
|
I updated the Automake files for you. I'll let @donnaaboise look at this and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional example under
applications/clawpack/euler/2d/triple. This runs the triple point shock problem as outlined here. The implementation has been verified.