Skip to content

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jan 7, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Difference from initial version #6153

  • All commands in yaml
  • Added couple of cross-references (mostly RTK)
  • Split chunky context files
  • Drafted irrelevant context files
  • Added .local gateway for environment and configuration files
  • Added AGENTS.md for Cursor
  • Refreshed frontend/README.md

How did you test this code?

  • Yet to be tested with real features
  • Ran couple of benchmarks related to context token consumption:
Task: Create banner component + API request for buildVersion

  What I need:
  1. How to create an RTK Query endpoint
  2. How to find/check the backend endpoint
  3. Basic component structure

  ---
  BEFORE (flat structure)

  | File                   | Lines | Why loaded                     |
  |------------------------|-------|--------------------------------|
  | quick-reference.md     | 293   | Component patterns, API basics |
  | api-integration.md     | 220   | RTK Query patterns             |
  | backend-integration.md | 277   | Find buildVersion endpoint     |
  | patterns.md            | 545   | API service patterns           |
  | ui-patterns.md         | 171   | Component structure            |

  Total: ~1,506 lines

  ❌ patterns.md loads everything - mobile patterns, CRUD modals, pagination - even though I only need basic API service patterns.

  ---
  AFTER (atomic structure)

  | File                   | Lines | Why loaded                 |
  |------------------------|-------|----------------------------|
  | quick-reference.md     | ~250  | Simplified, cross-refs     |
  | api-integration.md     | 220   | RTK Query patterns         |
  | backend-integration.md | 277   | Find buildVersion endpoint |
  | patterns/api.md        | ~160  | Only API patterns          |
  | ui-patterns.md         | 171   | Component structure        |

  Total: ~1,078 lines

  NOT loaded:
  - patterns/index.md - full example not needed
  - patterns/mobile.md.draft - irrelevant
  - feature-flags/* - not requested
  - forms.md.draft - not a form

  ---
  Comparison

  | Metric             | Before                                   | After | Saved           |
  |--------------------|------------------------------------------|-------|-----------------|
  | Lines              | 1,506                                    | 1,078 | 428 lines (28%) |
  | Irrelevant content | Mobile patterns, CRUD modals, pagination | None  | ✅              |
 Task: Auth form (sign-in + sign-up), email + password, responsive

  What I need:
  1. Form patterns (Yup + Formik validation)
  2. API endpoints for sign-in/sign-up
  3. Responsive UI patterns (Bootstrap)
  4. Error handling for auth failures
  5. State management for switching sign-in ↔ sign-up

  ---
  BEFORE (flat structure)

  | File                   | Lines | Why loaded                              |
  |------------------------|-------|-----------------------------------------|
  | quick-reference.md     | 293   | Bootstrap classes, general patterns     |
  | api-integration.md     | 220   | RTK Query mutations for auth            |
  | backend-integration.md | 277   | Find auth endpoints                     |
  | ui-patterns.md         | 171   | Responsive patterns, tabs for switching |
  | patterns.md            | 545   | Error handling, API patterns            |
  | forms.md               | 130   | Yup + Formik validation                 |

  Total: ~1,636 lines

  ❌ patterns.md loads mobile CRUD patterns, pagination, file downloads - none relevant for auth form
  ❌ forms.md loaded entirely even if only need validation schema example

  ---
  AFTER (atomic structure)

  | File                   | Lines | Why loaded                      |
  |------------------------|-------|---------------------------------|
  | quick-reference.md     | ~250  | Bootstrap classes, simplified   |
  | api-integration.md     | 220   | RTK Query mutations             |
  | backend-integration.md | 277   | Find auth endpoints             |
  | ui-patterns.md         | 171   | Tabs for sign-in/sign-up switch |
  | patterns/api.md        | ~160  | Error handling only             |

  Total: ~1,078 lines

  NOT loaded:
  - patterns/index.md - full example overkill for form
  - patterns/mobile.md.draft - irrelevant
  - feature-flags/* - not requested
  - forms.md.draft - drafted (would need to un-draft if forms are common)

  ---
  Comparison

  | Metric             | Before                                        | After | Saved           |
  |--------------------|-----------------------------------------------|-------|-----------------|
  | Lines              | 1,636                                         | 1,078 | 558 lines (34%) |
  | Irrelevant content | Mobile, pagination, file downloads, full CRUD | None  | ✅              |

kyle-ssg and others added 30 commits October 14, 2025 14:13
- Add missing developer documentation
- Refresh CONTRIBUTING.md
- Refresh the PR template
- Import developer docs and CONTRIBUTING.md to docs.flagsmith.com
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
@Zaimwa9 Zaimwa9 requested review from a team as code owners January 7, 2026 10:25
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team January 7, 2026 10:25
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 7, 2026 10:54am
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 7, 2026 10:54am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 7, 2026 10:54am

@Zaimwa9 Zaimwa9 requested a review from talissoncosta January 7, 2026 10:25
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6486 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6486 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6486 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6486 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6486 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6486 Finished ✅ Results

@@ -0,0 +1,25 @@
# Flagsmith Project Configuration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part was hardcoded in feature-flags so here it allows for local configuration without leaking

@@ -0,0 +1,130 @@
# Form Patterns (Yup + Formik)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drafted it as it uses Hoxton Mix guidelines I understood 😄

description: Generate a new RTK Query API service
---

<!-- TODO: Update /api-types-sync once OpenAPI schema is ready -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth waiting and having it complete

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this can be deleted

@khvn26
Copy link
Member

khvn26 commented Jan 7, 2026

@Zaimwa9 Can you check the docs build error? See https://vercel.com/flagsmith/docs/AovF2aVgZoAEMZrYYcnj4uGipEZz#L38

  
  Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
  Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.
  
  Exhaustive list of all broken links found:
  - Broken link on source page path = /project-and-community/development:
     -> linking to CLAUDE.md (resolved as: /project-and-community/CLAUDE.md)
  
      at throwError (/vercel/path0/docs/node_modules/@docusaurus/logger/lib/logger.js:80:11)
      at reportBrokenLinks (/vercel/path0/docs/node_modules/@docusaurus/core/lib/server/brokenLinks.js:250:47)
      at handleBrokenLinks (/vercel/path0/docs/node_modules/@docusaurus/core/lib/server/brokenLinks.js:282:5)
      at executeBrokenLinksCheck (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/buildLocale.js:119:47)
      at /vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/buildLocale.js:94:67
      at Object.async (/vercel/path0/docs/node_modules/@docusaurus/logger/lib/perfLogger.js:42:47)
      at buildLocale (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/buildLocale.js:94:31)
      at async runBuildLocaleTask (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/build.js:98:5)
      at async /vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/build.js:79:13
      at async tryToBuildLocale (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/build.js:75:9)
      at async /vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/build.js:35:9
      at async mapAsyncSequential (/vercel/path0/docs/node_modules/@docusaurus/utils/lib/jsUtils.js:21:24)
      at async Command.build (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/build/build.js:34:5)
      at async Promise.all (index 0)
      at async runCLI (/vercel/path0/docs/node_modules/@docusaurus/core/lib/commands/cli.js:56:5)
      at async file:///vercel/path0/docs/node_modules/@docusaurus/core/bin/docusaurus.mjs:44:3
}

@github-actions github-actions bot added docs Documentation updates and removed docs Documentation updates labels Jan 7, 2026
Base automatically changed from docs/agents-and-humans to main January 7, 2026 14:22
@matthewelwell matthewelwell requested review from a team as code owners January 7, 2026 14:22
@matthewelwell matthewelwell requested review from Holmus and emyller and removed request for a team January 7, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation updates front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants