fix(attachment): Avoid recursive lock of Sync object on worker detach
#8872
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to double locking of
mainSyncinsideWorkerStableAttachment::fini()(AttSyncLockGuard+BackgroundContextHolder)EngineCheckoutwill become useless (it uses inLCK_fini() -> LockManager::shutdownOwner()). IfEngineCheckoutwill not do its job, we can get a deadlock, for example insideLockManager::shutdownOwner():If the AST will be called for our worker attachment we will be stuck in this loop, AST cannot continue its execution due to lock on
mainSyncand attachment cannot finish its own routine due to recursive lock.This case can be reproduced with next steps.
It's very hard to reproduce due to race condition nature of the bug, but it can still happen accidentally in production.
v5 is also affected by this bug.