Split SuperLU solver and matrix #4061
Merged
+108
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into jhale/split-superlu-solver-matrix
jhale
commented
Feb 2, 2026
cpp/dolfinx/la/superlu_dist.cpp
Outdated
| template <typename T> | ||
| int SuperLUDistSolver<T>::solve(const la::Vector<T>& b, la::Vector<T>& u) const | ||
| { | ||
| std::int64_t m = _A_superlu_mat->Amat().index_map(0)->size_global(); |
Member
Author
There was a problem hiding this comment.
Breaks encapsulation, get from native SuperMatrix?
Member
Author
|
Compromise would be for solver to still take MatrixCSR and then construct and hold SuperLUDistMatrix internally, halves the Python boilerplate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the memory management of the SuperMatrix object separately from the solver in C++.
No changes in Python - doesn't seem worth the boiler plate at the minute.