fix - Dev-The empty Expensify Card Page display briefly in the first time going to Expensify Card#83633
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10af0dedca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const isLoading = !isOffline && (!cardSettings || cardSettings.isLoading) && !cardSettings?.hasOnceLoaded; | ||
|
|
||
| const renderContent = () => { | ||
| if (!!isLoading && !paymentBankAccountID) { | ||
| if (isLoading) { | ||
| return <FullScreenLoadingIndicator shouldUseGoBackButton />; |
There was a problem hiding this comment.
Preserve cached card list while first post-upgrade fetch runs
This now shows a full-screen loader whenever isLoading is true, but hasOnceLoaded is only set by the new success path. For users upgrading with existing cached paymentBankAccountID data (which won’t have hasOnceLoaded yet), the optimistic isLoading: true update will hide the already-available card list until the network read succeeds; on slow/failing connections this regresses offline-first behavior and can block access to previously cached cards.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-27.at.09.04.55.movAndroid: mWeb ChromeScreen.Recording.2026-02-27.at.08.55.36.moviOS: HybridAppScreen.Recording.2026-02-27.at.08.58.58.moviOS: mWeb SafariScreen.Recording.2026-02-27.at.08.53.45.movMacOS: Chrome / SafariScreen.Recording.2026-02-27.at.08.51.04.mov |
Explanation of Change
Fixed Issues
$ #83384
PROPOSAL: #83384 (comment)
Tests
Precondition: A workspace with Expensify Card set up and some cards assigned.
Offline tests
same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-02-27.01-12-54.mp4
Android: mWeb Chrome
2026-02-27.00-21-34.mp4
iOS: Native
iOS: mWeb Safari
https://github.com/user-attachments/assets/92c0a6f2-a670-4948-93fb-1245bff8408aMacOS: Chrome / Safari
2026-02-27.00-19-30.mp4