Skip to content

Fix 'Not Found' page flash after deleting expense #83613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

Fix 'Not Found' page flash after deleting expense #83613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pages/inbox/DeleteTransactionNavigateBackHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ import ONYXKEYS from '@src/ONYXKEYS';
/**
* Component that does not render anything but isolates the NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL
* subscription from ReportScreen. Clears the URL after interactions complete
* when the report is focused.
* when the report is no longer focused.
*/
function DeleteTransactionNavigateBackHandler() {
const isFocused = useIsFocused();
const [deleteTransactionNavigateBackUrl] = useOnyx(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL);

useEffect(() => {
if (!isFocused || !deleteTransactionNavigateBackUrl) {
if (isFocused || !deleteTransactionNavigateBackUrl) {
return;
}
if (doesDeleteNavigateBackUrlIncludeDuplicatesReview(deleteTransactionNavigateBackUrl)) {
return;
}
// Clear the URL after all interactions are processed to ensure all updates are completed before hiding the skeleton
// Clear the URL only after we navigate away to avoid a brief Not Found flash.
// eslint-disable-next-line @typescript-eslint/no-deprecated
InteractionManager.runAfterInteractions(() => {
requestAnimationFrame(() => {
Expand Down
Loading