Strip accounting-style parentheses from expense report names in LHN

src/libs/ReportNameUtils.ts

@@ -142,13 +142,22 @@
 
 let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
 
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => {
         allPersonalDetails = value;
     },
 });
 
+/**
+ * Strips accounting-style parentheses from currency amounts in report names.
+ * The backend formats negative amounts with parentheses (e.g., "($25.00)") instead of
+ * a minus sign. This function converts them to the standard format (e.g., "$25.00").
+ */
+function stripAccountingBrackets(reportName: string): string {
+    return reportName.replaceAll(/\(([^)]*\d[^)]*)\)/g, '$1');
+}
+
 function generateArchivedReportName(reportName: string): string {
     // eslint-disable-next-line @typescript-eslint/no-deprecated
     return `${reportName} (${translateLocal('common.archived')}) `;
@@ -335,7 +344,7 @@
     }
 
     if (report?.reportName && isExpenseReport(report)) {
-        return report.reportName;
+        return stripAccountingBrackets(report.reportName);
     }
 
     const moneyRequestTotal = getMoneyRequestSpendBreakdown(report).totalDisplaySpend;
@@ -780,7 +789,7 @@
     }
 
     if (report?.reportName && report.type === CONST.REPORT.TYPE.EXPENSE) {
-        return report?.reportName;
+        return stripAccountingBrackets(report.reportName);
     }
 
     if (isTaskReport(report)) {

src/libs/ReportUtils.ts

@@ -1015,7 +1015,7 @@
 };
 
 let conciergeReportIDOnyxConnect: OnyxEntry<string>;
 Onyx.connect({
     key: ONYXKEYS.CONCIERGE_REPORT_ID,
     callback: (value) => {
         conciergeReportIDOnyxConnect = value;
@@ -1023,7 +1023,7 @@
 });
 
 const defaultAvatarBuildingIconTestID = 'SvgDefaultAvatarBuilding Icon';
 Onyx.connect({
     key: ONYXKEYS.SESSION,
     callback: (value) => {
         // When signed out, val is undefined
@@ -1041,7 +1041,7 @@
 let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
 let allPersonalDetailLogins: string[];
 let currentUserPersonalDetails: OnyxEntry<PersonalDetails>;
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => {
         if (currentUserAccountID) {
@@ -1053,7 +1053,7 @@
 });
 
 let allReportsDraft: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_DRAFT,
     waitForCollectionCallback: true,
     callback: (value) => (allReportsDraft = value),
@@ -1062,7 +1062,7 @@
 let allPolicies: OnyxCollection<Policy>;
 let hasPolicies: boolean;
 let policiesArray: Policy[] = [];
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1073,7 +1073,7 @@
 });
 
 let allPolicyDrafts: OnyxCollection<Policy>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY_DRAFTS,
     waitForCollectionCallback: true,
     callback: (value) => (allPolicyDrafts = value),
@@ -1081,7 +1081,7 @@
 
 let allReports: OnyxCollection<Report>;
 let reportsByPolicyID: ReportByPolicyMap;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1117,14 +1117,14 @@
 });
 
 let betaConfiguration: OnyxEntry<BetaConfiguration> = {};
 Onyx.connect({
     key: ONYXKEYS.BETA_CONFIGURATION,
     callback: (value) => (betaConfiguration = value ?? {}),
 });
 
 let allTransactions: OnyxCollection<Transaction> = {};
 let reportsTransactions: Record<string, Transaction[]> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -6727,7 +6727,7 @@
     const storedNonReimbursableTotal = nonReimbursableTotal * -1;
     const report = chatReportID ? getReportOrDraftReport(chatReportID) : undefined;
     const policyName = getPolicyName({report});
-    const formattedTotal = convertToDisplayString(storedTotal, currency);
+    const formattedTotal = convertToDisplayString(Math.abs(storedTotal), currency);
     // This will be fixed as part of https://github.com/Expensify/Expensify/issues/507850
     // eslint-disable-next-line @typescript-eslint/no-deprecated
     const policyReal = getPolicy(policyID);

tests/unit/ReportNameUtilsTest.ts

@@ -744,6 +744,25 @@ describe('ReportNameUtils', () => {
             expect(reportName).toBe(CONST.REPORT.DEFAULT_EXPENSE_REPORT_NAME);
         });
 
+        it('should strip accounting-style parentheses from expense report reportName', () => {
+            // Given an expense report with a reportName containing accounting-style parenthesized amount
+            const expenseReport: Report = {
+                ...createExpenseReport(202),
+                reportID: '202',
+                reportName: 'Workspace owes ($25.00)',
+                policyID: '202',
+                type: CONST.REPORT.TYPE.EXPENSE,
+                total: -2500,
+                currency: 'USD',
+            };
+
+            // When we get the money request report name
+            const reportName = getMoneyRequestReportName({report: expenseReport});
+
+            // Then it should strip the accounting-style parentheses
+            expect(reportName).toBe('Workspace owes $25.00');
+        });
+
         it('should not return empty string for expense report with empty reportName when policy has a normal fieldList', () => {
             // Given an expense report with empty reportName
             const expenseReport: Report = {

tests/unit/ReportUtilsTest.ts

@@ -10098,7 +10098,7 @@ describe('ReportUtils', () => {
             const total = 100;
             const currency = CONST.CURRENCY.USD;
             const expenseReport = buildOptimisticExpenseReport({chatReportID, policyID: undefined, payeeAccountID: 1, total, currency, betas: [CONST.BETAS.ALL]});
-            expect(expenseReport.reportName).toBe(`${fakePolicy.name} owes ${convertToDisplayString(-total, currency)}`);
+            expect(expenseReport.reportName).toBe(`${fakePolicy.name} owes ${convertToDisplayString(total, currency)}`);
         });
 
         it('should set reportName to "New Report" when policy field list is empty', async () => {

tests/unit/libs/getClipboardTextTest.ts

@@ -1,5 +1,5 @@
-import Parser from '@libs/Parser';
 import getClipboardText from '@libs/Clipboard/getClipboardText';
+import Parser from '@libs/Parser';
 
 jest.mock('@libs/Parser', () => ({
     // eslint-disable-next-line @typescript-eslint/naming-convention