Skip to content

[No QA] Update Manage-Company-Cards.md#83601

Open
brianlee-expensify wants to merge 2 commits intomainfrom
brianlee-expensify-patch-2
Open

[No QA] Update Manage-Company-Cards.md#83601
brianlee-expensify wants to merge 2 commits intomainfrom
brianlee-expensify-patch-2

Conversation

@brianlee-expensify
Copy link
Contributor

Explanation of Change

provide more clarity on where to send AMEX feed info

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@brianlee-expensify
Copy link
Contributor Author

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

1. Complete the required [Amex forms](https://drive.google.com/file/d/1zqDA_MCk06jk_fWjzx2y0r4gOyAMqKJe/view?usp=sharing).
2. Email the forms to American Express.
3. Submit the provided production file information to Expensify.
3. Once American Express provides you with the feed details, please send them over to concierge@expensify.com.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency note: The Mastercard and Visa sections both direct users to submit information via the submission form, but this American Express step directs users to email concierge@expensify.com instead.

If the email address is intentionally the correct channel for AMEX feed details, this is fine -- but it may be worth confirming whether the same Typeform submission link should be used here for consistency, or whether a brief note explaining why AMEX uses a different submission method would help users understand the difference.

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single-line change to step 3 of the American Express commercial card feed setup instructions. The goal is to clarify where users should send their Amex feed information. The addition of the specific email address (concierge@expensify.com) is a meaningful improvement -- the old text ("Submit the provided production file information to Expensify") was vague about both what to submit and how to submit it. However, the new phrasing introduces tone and structure inconsistencies with the rest of the document that should be addressed before merging.

Scores Summary

  • Readability: 6/10 - The new sentence is longer and more conversational than necessary for a numbered instructional step. The conditional clause ("Once American Express provides you with the feed details") front-loads a dependency that breaks the direct, imperative pattern used in every other numbered step in this document. The phrase "send them over" is informal and imprecise.
  • AI Readiness: 7/10 - The explicit email address is a positive addition for AI retrieval -- it provides a concrete, actionable piece of information. However, the conditional phrasing ("Once...provides you") makes it harder for AI systems to extract the core action from this step.
  • Style Compliance: 5/10 - This is the weakest area. The word "please" breaks the imperative voice used consistently throughout the document. The casual phrasing "send them over" does not match the professional, direct tone of comparable steps (e.g., "Submit the distribution ID to Expensify via the submission form" in the Mastercard section). Every other numbered step in this file uses a bare imperative verb to begin the sentence.

Key Findings

Positive aspects:

  • Adding the specific email address (concierge@expensify.com) removes real ambiguity -- users previously had no clear channel for submitting their Amex feed information.
  • Replacing "production file information" with "feed details" is a reasonable simplification of terminology.

Issues that should be addressed:

  1. Tone inconsistency with "please": No other step in this document uses "please." Instructional numbered steps in HelpDot documentation should use direct imperative voice. Compare:

    • Mastercard step 3: "Submit the distribution ID to Expensify via the submission form."
    • Visa step 3: "Submit the file details via the submission form."
    • New Amex step 3: "Once American Express provides you with the feed details, please send them over to concierge@expensify.com."
  2. Conditional clause breaks the step pattern: Every other numbered step begins with an imperative verb (Complete, Email, Contact, Request, Submit, etc.). Beginning with "Once American Express provides you..." makes this read as guidance or a note rather than an action step. If the dependency needs to be communicated, consider splitting it into two steps or adding a brief note.

  3. "Send them over" is too informal: The phrase "send them over" is colloquial. The rest of the document uses precise verbs like "Submit," "Email," and "Provide." The new step should match this register.

  4. Bare email address: The email concierge@expensify.com is not formatted as a clickable mailto link. For consistency and usability, consider using a markdown link: [concierge@expensify.com](mailto:concierge@expensify.com).

Recommendations

Suggested rewrite for step 3:

3. Submit the feed details provided by American Express to [concierge@expensify.com](mailto:concierge@expensify.com).

This revision:

  • Begins with an imperative verb ("Submit"), matching every other step in the document.
  • Removes "please" and "send them over" to align with the professional, direct tone.
  • Retains the improved terminology ("feed details" instead of "production file information").
  • Keeps the valuable addition of the specific email address.
  • Uses a mailto link for better usability.
  • Is concise and parallel with the Mastercard and Visa steps.

If the intent is to signal that this step depends on American Express responding first, consider adding a brief note after the step rather than embedding the condition into the step itself. For example:

3. Submit the feed details provided by American Express to [concierge@expensify.com](mailto:concierge@expensify.com).

**Note:** American Express will provide the feed details after processing your forms from step 1.

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/Manage-Company-Cards.md -- Single-line change to American Express step 3. The added email address is a clear improvement; the phrasing needs revision for tone and structural consistency.

Note: Detailed line-by-line feedback has been provided as inline comments.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team February 26, 2026 22:35
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @kadiealexander

@melvin-bot melvin-bot bot requested a review from kadiealexander February 26, 2026 22:36
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2026

@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 26, 2026 22:36
@stephanieelliott
Copy link
Contributor

Adding someone else to merge

@github-actions github-actions bot changed the title Update Manage-Company-Cards.md [No QA] Update Manage-Company-Cards.md Feb 26, 2026
@OSBotify
Copy link
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://6e26861a.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants