Skip to content

Strip Hermes debug info from production iOS bytecode #83256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roryabraham wants to merge 5 commits into
base: main
Choose a base branch
from
+28 −0
Open

Strip Hermes debug info from production iOS bytecode #83256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bec8a37
Strip Hermes debug info from production iOS bytecode (standalone)
roryabraham Feb 23, 2026
cd50377
Add patch documentation to details.md
roryabraham Feb 26, 2026
e52fc10
Merge branch 'main' of github.com:Expensify/App into rory-strip-herme…
roryabraham Feb 26, 2026
e29d933
Fix: preserve -output-source-map for debug builds with source maps
roryabraham Feb 27, 2026
3fffb57
Merge remote-tracking branch 'origin/main' into rory-strip-hermes-deb…
roryabraham Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions patches/react-native/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,10 @@
- Upstream PR/issue: This is not intended to be upstreamed, since this is a low-level fix very specific to the Expensify app's requirements.
- E/App issue: [#76859](https://github.com/Expensify/App/issues/76859)
- PR introducing patch: [#76154](https://github.com/Expensify/App/pull/76154)

### [react-native+0.81.4+028+strip-hermes-debug-info.patch](react-native+0.81.4+028+strip-hermes-debug-info.patch)

- Reason: Always pass `-output-source-map` to `hermesc` for production iOS builds, stripping ~13.4MB of debug metadata from the Hermes bytecode. Previously this flag was only passed when `SOURCEMAP_FILE` was set; if the build environment didn't propagate that variable, debug info remained in the shipped bundle.
- Upstream PR/issue: This should ideally be the default behavior upstream, but no PR has been filed yet.
- E/App issue: [#83000](https://github.com/Expensify/App/issues/83000)
- PR introducing patch: [#83256](https://github.com/Expensify/App/pull/83256)
21 changes: 21 additions & 0 deletions patches/react-native/react-native+0.81.4+028+strip-hermes-debug-info.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
diff --git a/node_modules/react-native/scripts/react-native-xcode.sh b/node_modules/react-native/scripts/react-native-xcode.sh
--- a/node_modules/react-native/scripts/react-native-xcode.sh
+++ b/node_modules/react-native/scripts/react-native-xcode.sh
@@ -173,7 +173,7 @@
else
EXTRA_COMPILER_ARGS=-O
fi
- if [[ $EMIT_SOURCEMAP == true ]]; then
+ if [[ $EMIT_SOURCEMAP == true || $DEV != true ]]; then
EXTRA_COMPILER_ARGS="$EXTRA_COMPILER_ARGS -output-source-map"
fi
"$HERMES_CLI_PATH" -emit-binary -max-diagnostic-width=80 $EXTRA_COMPILER_ARGS -out "$DEST/$BUNDLE_NAME.jsbundle" "$BUNDLE_FILE"
@@ -183,6 +183,8 @@
"$NODE_BINARY" "$COMPOSE_SOURCEMAP_PATH" "$PACKAGER_SOURCEMAP_FILE" "$HBC_SOURCEMAP_FILE" -o "$SOURCEMAP_FILE"
rm "$HBC_SOURCEMAP_FILE"
rm "$PACKAGER_SOURCEMAP_FILE"
+ elif [[ $DEV != true ]]; then
+ rm -f "$DEST/$BUNDLE_NAME.jsbundle.map"
fi
BUNDLE_FILE="$DEST/$BUNDLE_NAME.jsbundle"
fi
Loading