-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[No QA] ci: Add Sentry build size analysis #82952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rinej
wants to merge
21
commits into
Expensify:main
Choose a base branch
from
callstack-internal:set-up-sentry-adhoc-size-analysis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+489
−63
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4e9d873
set-up-sentry-release-upload
rinej 5f497e2
upload adhocsbuilds to Sentry
rinej b63b014
install sentry-cli newest version
rinej 99058c0
add notice log with bundle url
rinej 103f6f4
add table with sentry bundle urls
rinej 9ecdfff
Merge branch 'main' into set-up-sentry-adhoc-size-analysis
rinej d59ded8
chore: remove todos comments
rinej f404b09
Merge branch 'main' into set-up-sentry-release-size-analysis
rinej 0036053
Merge branch 'main' into set-up-sentry-adhoc-size-analysis
rinej b2974cd
add upload sentry bundle logic to separate files
rinej d34193f
bump sentry-cli version
rinej 043541a
generate aab for adhocs
rinej 956908f
Merge branch 'main' into set-up-sentry-release-size-analysis
rinej 272110a
adjust after mergin main
rinej 0a0e3ff
Merge branch 'main' into set-up-sentry-adhoc-size-analysis
rinej 75f8d6b
Merge branch 'main' into set-up-sentry-adhoc-size-analysis
rinej c3ad3df
add secondary rock build for aab format
rinej ce6d4ce
Merge branch 'main' into set-up-sentry-adhoc-size-analysis
rinej 19722f3
Merge branch 'set-up-sentry-release-size-analysis' into set-up-sentry…
rinej c28d17e
unify sentry bundle upload for adhocs and release
rinej c7cc468
unify the sentry bundle upload for IOS
rinej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than building an
.aabseparately, can we just try always building an.aabin the rock action above? I looked at the source code and bit and it suggests we should be able to distribute AdHoc builds with.aabjust fine: https://github.com/callstackincubator/android/blob/4cedf4d9b5c167452c96fe67233577e0fde9a025/action.yml#L387-L394Then we can convert the
.aabinto an.apkbelow (we already do that). and we can upload the.aabfrom the main build into Sentry