[HOLD][No QA] Set up Sentry release size analysis#82937
Closed
rinej wants to merge 5 commits intoExpensify:mainfrom
Closed
[HOLD][No QA] Set up Sentry release size analysis#82937rinej wants to merge 5 commits intoExpensify:mainfrom
rinej wants to merge 5 commits intoExpensify:mainfrom
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This was referenced Feb 19, 2026
roryabraham
requested changes
Feb 19, 2026
.github/workflows/deploy.yml
Outdated
| if: ${{ fromJSON(env.SHOULD_BUILD_APP) }} | ||
| continue-on-error: true | ||
| timeout-minutes: 5 | ||
| # TODO: Remove --log-level debug before merging |
Contributor
There was a problem hiding this comment.
Let's just remove the TODO, leave --log-level debug, then test this by merging and cherry-picking to staging
Contributor
|
@DylanDylann no C+ review needed here |
Contributor
|
We can also finish testing #82952 first to validate the idea |
Contributor
|
Putting this on HOLD for #82952 |
51 tasks
Contributor
|
I think this has been combined into #82952 |
Contributor
Author
|
I was just about to close it, same timing :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD for #82952
Explanation of Change
Adds Sentry https://docs.sentry.io/platforms/react-native/size-analysis/ upload steps to the deploy.yml workflow for both Android (AAB) and iOS (IPA) builds. After each staging build, the produced binary is uploaded to Sentry so we can track app binary size across releases and detect regressions.
Fixed Issues
$ #82850
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari