Draft
Conversation
| const componentRef = view.createComponent(rendering.componentImplementation); | ||
| componentRef.setInput('rendering', rendering.componentDefinition); | ||
| if (this._inputs) { | ||
| this._setComponentInputs(componentRef, this._inputs); |
There was a problem hiding this comment.
Within this _setComponentInputs there is an issue, I don't know why it is an issue now, maybe something changed with setInput in Angular 20, but when it tries to set an input that doesn't exist on the component placed in a placeholder, it will throw an error.
This now happens with a lot of components in DynamicRow because the DynamicRow will try to set the context input on all components placed in a column.
I think we can change the _setComponentInputs to something like this (untested):
private _setComponentInputs(
componentRef: ComponentRef<unknown>,
inputs: { [key: string]: unknown }
) {
Object.entries(inputs).forEach(([input, inputValue]) => {
// Only set an input if it exists on the component
if (input in componentRef) {
componentRef.setInput(input, inputValue)
}
});
}related error
NG0303: Can't set value of the 'context' input on the '_MemberGetMemberWidgetComponent' component. Make sure that the 'context' property is declared as an input using the input() or model() function or the @Input() decorator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Testing Details
Types of changes