Backport many patches from Spigot, Paper, and some Paper forks#157
Backport many patches from Spigot, Paper, and some Paper forks#157cswhite2000 merged 3 commits intoElectroid:mainfrom
Conversation
| nbttagcompound.setShort("Health", (short) ((byte) this.d)); | ||
| nbttagcompound.setShort("Age", (short) this.b); | ||
| - nbttagcompound.setShort("Value", (short) this.value); | ||
| + nbttagcompound.setInt("Value", this.value); // Paper - save as Integer |
There was a problem hiding this comment.
This seems like it could cause issues https://minecraft.wiki/w/Experience#Data_values
Does Sportpaper handle this gracefully if the sizes don't match?
and if someone were to make a world with this on a sportpaper server, does minecraft 1.8 handle this gracefully if loaded directly in singleplayer?
There was a problem hiding this comment.
No idea, it made sense given that it was in upstream Paper in older versions and when reading details about the issue, but the issue has since been resolved as of 1.17. value is stored as an int in EntityExperienceOrb to begin with on legacy.
I'm just inclined to drop it if we're concerned.
There was a problem hiding this comment.
It looks like this is handled gracefully as long its a number, at least server side
So this is should be fine to keep.
| nbttagcompound.setShort("Health", (short) ((byte) this.d)); | ||
| nbttagcompound.setShort("Age", (short) this.b); | ||
| - nbttagcompound.setShort("Value", (short) this.value); | ||
| + nbttagcompound.setInt("Value", this.value); // Paper - save as Integer |
There was a problem hiding this comment.
It looks like this is handled gracefully as long its a number, at least server side
So this is should be fine to keep.
This is a large patch bringing over virtually all of Overcast Community's internal SportPaper changes. I have intentionally excluded the following patches:
All of the changes here have been run in production for over 2 months.
A comprehensive list of all changes:
Scripts, workflow, and submodules:
API
Server:
Supersedes #149 as it also includes those changes
Edit:
Should someone need to refer back to this, this PR also updates the MySQL and JDBC connectors.