Issue #25 : Created the Greetings Page#146
Open
LEARNER-dakshesh wants to merge 2 commits intoEkaAI-Tech:masterfrom
Open
Issue #25 : Created the Greetings Page#146LEARNER-dakshesh wants to merge 2 commits intoEkaAI-Tech:masterfrom
LEARNER-dakshesh wants to merge 2 commits intoEkaAI-Tech:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
Bro, can you make it lighter by using SVG files? The app size is increasing drastically. You can simply convert image files to SVGs if a proper SVG image is not found. |
Author
|
I have converted the images to svg . Could you please check it |
Author
|
Bro @sapatevaibhav i have submitted the updated code . Could you please merge it . |
Collaborator
|
please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added Greetings page in the home page where the user can see different types of expressions and listen to its pronunciation . I haven't got some of the specific images like for good morning and good night because i was unable to find image through which user can relate to.