Open
Conversation
Necromos
suggested changes
Feb 17, 2019
Contributor
Necromos
left a comment
Necromos
left a comment
There was a problem hiding this comment.
Hey! First of all thanks for this PR! GJ 👍
It will require quite a bunch of work still tho ⚡️
| */ | ||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Please, get rid of this meta data :)
| if (originPath !== null) { | ||
| distributionConfig.Origins[0].OriginPath = originPath; | ||
| } else { | ||
| delete distributionConfig.Origins[0].OriginPath; |
Contributor
There was a problem hiding this comment.
This else block will:
- never be called
- will ruin backward compatibility if will be called in any particular way
Please, get rid of it :)
| distributionConfig.Origins[0].OriginPath = `/${this.options.stage}`; | ||
| const originPath = this.getConfig('originPath', `/${this.options.stage}`); | ||
|
|
||
| if (originPath !== null) { |
Contributor
There was a problem hiding this comment.
This comparison will always be true as getConfig returns default value in case of originPath missing in config.
I would suggest to get rid of it :)
| custom: | ||
| apiCloudFront: | ||
| domain: my-custom-domain.com | ||
| originPath: /some-path |
Contributor
There was a problem hiding this comment.
Can we get some additional description about this field? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to modify
originPathfor my current project and because this value is hardcoded in the current version of the plugin, I've made this option configurable and I hope you can accept this PR asap.