Add storefront custom domain configuration for Shopi.lk#765
Add storefront custom domain configuration for Shopi.lk#765ruzny-ramzan wants to merge 1 commit intoDomain-Connect:masterfrom
Conversation
|
Linter OK: |
kerolasa
left a comment
There was a problem hiding this comment.
The template file should not use separate directory. Please move it in correct place, using expected name:
mv ./shopi.lk/storefront.json ./shopi.lk.storefront.json
Secondly, the linter failed to detect issue because the template was in unexpected directory. I took liberty to have check the template manually, and got the following error. Please fix this one as well.
$ dc-template-linter shopi.lk.storefront.json
2026-02-11T10:44:29Z ERR code=DCTL1012 dctl_note="record host must not be @ when template hostRequired is false" groupid= record=0 template=shopi.lk.storefront.json type=CNAME
https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1012
|
Also very confusing is the PR description, which looks legit, but contains statements like "syncRedirectDomain is specified for synchronous redirect flow" which do not match the template not containing syncRedirectDomain at all. |
pawel-kow
left a comment
There was a problem hiding this comment.
file naming/location and other issues
| "providerName": "Shopi.lk", | ||
| "serviceId": "storefront", | ||
| "serviceName": "Shopi.lk Storefront", | ||
| "version": 2, |
There was a problem hiding this comment.
You nailed it. I thought version 2 get higher priority that's why I set it to 2. If I want to set it back to 1, then no issues. I'll do it.
Description
Adds a new Domain Connect template for Shopi.lk Storefront service.
This template enables automatic DNS configuration for connecting a customer domain to a Shopi storefront. The template only provisions routing DNS records required for SaaS onboarding. SSL validation and certificate provisioning are handled separately by Shopi via Cloudflare for SaaS using HTTP ownership validation.
This template is intentionally limited to routing configuration and does not include TXT verification or SSL validation records.
Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis served by a webserverChecklist of common problems
syncPubKeyDomainspecifiedsyncRedirectDomainis specified for synchronous redirect flow%host%in host attributeessentialsetting used appropriatelyTemplate Behavior Notes
This template provisions:
It intentionally does NOT provision:
These are handled dynamically by Shopi backend services after DNS routing is established.
Example variable values