Updates, development environment#55
Conversation
Cargo.toml
Outdated
| log = "0.4.14" | ||
| serde_json = "1.0.64" | ||
| serde = "1.0.124" | ||
| sqlx = { version = "~0.8.1", features = ["postgres", "chrono", "uuid"] } |
There was a problem hiding this comment.
Could we just have version = ">=0.7, <1.0"?
There is no reason to pin it to a very specific version except if it's known that it would break
There was a problem hiding this comment.
Please replace these tilde dependency specifications with standard semver dependencies.
ie.
sqlx = { version = "0.8", ... }
Dependencies specifications should always use the default semver compatibility unless there is a known semver violation in the dependency that must be worked around.
There was a problem hiding this comment.
This PR should also bump the semver version of this crate to 0.6.0 since sqlx is a public dependency.
Diggsey
left a comment
Diggsey
left a comment
There was a problem hiding this comment.
Thanks for the PR, and sorry for the delay in reviewing!
Cargo.toml
Outdated
| log = "0.4.14" | ||
| serde_json = "1.0.64" | ||
| serde = "1.0.124" | ||
| sqlx = { version = "~0.8.1", features = ["postgres", "chrono", "uuid"] } |
There was a problem hiding this comment.
Please replace these tilde dependency specifications with standard semver dependencies.
ie.
sqlx = { version = "0.8", ... }
Dependencies specifications should always use the default semver compatibility unless there is a known semver violation in the dependency that must be worked around.
Cargo.toml
Outdated
| log = "0.4.14" | ||
| serde_json = "1.0.64" | ||
| serde = "1.0.124" | ||
| sqlx = { version = "~0.8.1", features = ["postgres", "chrono", "uuid"] } |
There was a problem hiding this comment.
This PR should also bump the semver version of this crate to 0.6.0 since sqlx is a public dependency.
devsupport/.gitignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| db/ | |||
There was a problem hiding this comment.
Please remove these devsupport files.
There was a problem hiding this comment.
See https://medium.com/@peter_graham/how-to-create-a-local-gitignore-1b19f083492b for how to ignore these files for you locally.
envrc.example
Outdated
| @@ -0,0 +1,7 @@ | |||
| export db_socket_path=$(echo $(pwd)/devsupport/db_sockets) | |||
flake.lock
Outdated
| @@ -0,0 +1,61 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove these flake files. I don't use nix and have no way of maintaining them.
|
@nyarly I realise I didn't explain clearly, but:
This is actually incorrect - in Rust, |
|
I'll try to get these updates done over the weekend |
|
Thanks! |
* fix(dev): add development workspace support * chore: update dotenv -> dotenvy, sqlx -> 0.8.1 * fix: allow dead_code for MutexGuard * feat(cargo): loosening version requirements on dependencies * chore: update tokio dependency * fix: remove local development files * fix: versions should use default dependency constraints
3 participants
Apologies in advance if this PR is presumptuous.
The primary motivation here was to be able to add sqlxmq to a project that's using sqlx 0.8.1 already. (There are a number of forks of sqlxmq already just to do this, but none had opened a PR.)
I wanted to ensure that I could run tests for sqlxmq in the process, and set up a development environment with
nix develop, and some light scripting to run a development PostgreSQL instance.Finally, dependencies on other crates have been loosened with
~to make it easier to integratesqlxmqinto applications.