-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 15.2.3 to 16.1.5 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645 - https://snyk.io/vuln/SNYK-JS-NEXT-15105315
Summary of ChangesHello @iamdrewfortini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk upgrades the next package from a v15 canary release to a v16 beta release to fix two high-severity vulnerabilities. The change itself is just the version bump in package.json, but it has significant implications. My review comment on that file provides a critical checklist for you before merging: you must manually update the pnpm-lock.yaml file, conduct thorough testing for breaking changes due to the major version jump, and check for necessary updates to related dependencies like eslint-config-next.
| "@stackframe/stack-shared": "workspace:*", | ||
| "convex": "^1.27.0", | ||
| "next": "15.2.3", | ||
| "next": "16.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR upgrades next across a major version boundary (from a v15 canary to a v16 beta). As noted in the PR description, the pnpm-lock.yaml file has not been updated. This is a critical step that must be done manually.
- Run
pnpm installto update the lock file and commit the changes. Merging without this will not apply the security fix and can lead to inconsistent dependency resolution. - Since this is a major version upgrade, it likely contains breaking changes. Thoroughly test the application to ensure it functions correctly.
- Check for peer dependency warnings after updating. Packages like
eslint-config-next(currently on14.2.5) may need to be upgraded for compatibility with Next.js 16.
Snyk has created this PR to fix 2 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
examples/convex/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
SNYK-JS-NEXT-15105315
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling