Lightweight module system setup for shared code#18
Open
dfcowell wants to merge 2 commits intoDevographics:mainfrom
Open
Lightweight module system setup for shared code#18dfcowell wants to merge 2 commits intoDevographics:mainfrom
dfcowell wants to merge 2 commits intoDevographics:mainfrom
Conversation
This PR takes a very light touch to introducing yarn workspaces v1 and a shared module in the "common" directory.
|
❌ Deploy Preview for stateofcss2021 failed. 🔨 Explore the source changes: 645945d 🔍 Inspect the deploy log: https://app.netlify.com/sites/stateofcss2021/deploys/61ac30c2f704ed0008462dc4 |
Contributor
Author
|
Just a couple of comments on this one.
|
b3nk3
reviewed
Dec 8, 2021
Contributor
b3nk3
left a comment
There was a problem hiding this comment.
This is a very neat approach. Clear and concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes a very light touch to introducing yarn workspaces v1 and a shared module in the "common" directory.
Basically the same as my last PR (#17) except it doesn't completely rearrange the project directories.