-
Notifications
You must be signed in to change notification settings - Fork 17
[WIP] Upgrade chakra-ui to v3 #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # package-lock.json # package.json
|
@uday-rana @lilyhuang-github @humphd I couldn't quite figure out why the e2e test is stuck. I'll keep investigating but any help is appreciated 🙏 |
|
@theoforger I was running into a similar problem in #843 a few commits ago but with a different error message. Not sure if there's any correlation but thought I'd mention it. https://github.com/DevelopingSpace/starchart/actions/runs/14303212753/job/40081313383 |
|
@humphd @uday-rana Just a couple problems left: AnimationsAlthough animations are glitchy after this migration, the problem seems to resolve itself once React is updated to 19. As I mentioned here: #841, the React upgrade mostly works, except for some issues with its mobile layout, which may or may not still exist after the chakra UI v3 migration. How do we want to approach this? Font/Margin/Padding SizesChakra UI v3 changed its sizing in many places. After this migration the website doesn't look exactly the same as before. Should we focus on replicating the old layout or making the current one look nice? |
|
To future maintainers: This migration is almost complete. It's only blocked by an animation bug which can be fixed by upgrading React to 19, and some minor UI tweaks. I put a lot of efforts into this PR and I'd love to see it merged some day. Feel free to reach out to me for collaboration. Thanks! 😃 |
Description
chakra-uiversion 3 introduced many breaking changes. This PR is an attempt to upgradeChanges
@emotion/styled,framer-motion,@chakra-ui/icons(migrated toreact-iconssince chakra stopped supporting their icons library)tsconfig.jsonto targetESNext.useToasthook in favor oftoasterfrom the code snippet