Project cleanup and planning for swift-configuration rewrite #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on from DevFoundation
duncan-daydream
force-pushed
the
duncan/swift-configuration
branch
from
cee2868 to
c6ee212
Compare
Code Coverage ReportOverall Coverage: 100.00% (3 of 3) DevConfiguration: 100.00% (3 of 3)
|
Plans/Architecture Plan.md
Outdated
| func value(for variable: ConfigVariable<[Bool]>) -> [Bool] | ||
| func value(for variable: ConfigVariable<[String]>) -> [String] | ||
| func value(for variable: ConfigVariable<[Int]>) -> [Int] | ||
| func value(for variable: ConfigVariable<[Double]>) -> [Double] |
There was a problem hiding this comment.
Is there a subscript version of these?
Collaborator
Author
There was a problem hiding this comment.
You mean like _ = configDataSource[.darkMode]?
…olidate behavior in StructuredConfigReader
|
auto privacy probably needs to cover string arrays as well. |
prachigauriar
approved these changes
Jan 10, 2026
prachigauriar
left a comment
prachigauriar
left a comment
There was a problem hiding this comment.
Approving, but note that whatever auto privacy setting we have for strings should likely apply to string arrays as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.