Conform auth adapter to Mongo adapter#504
Merged
renatodellosso merged 10 commits intomainfrom May 1, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
tests/unit/lib/DbInterfaceAuthAdapter.test.ts:267
- The test manually assigns the id from _id; consider ensuring that the adapter itself automatically maps _id to id, so that tests do not need to adjust the data manually.
foundUser!.id = foundUser!._id!.toString();
…catur-Robotics/Gearbox into conform-auth-adapter-to-mongo-adapter
There was a problem hiding this comment.
Pull Request Overview
This PR updates the auth adapter and related tests so that its behavior conforms to the Mongo adapter. Key changes include:
- Updating calls to getUserByAccount to pass explicit provider and providerAccountId properties.
- Removing tests that check for error conditions on missing or non-existent user/session identifiers.
- Adding new API methods (e.g., addOrUpdateObject, findObjectAndUpdate, deleteObjects, findObjectAndDelete) to various DbInterface classes and updating related type definitions.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/lib/DbInterfaceAuthAdapter.test.ts | Updated tests and removed redundant error handling tests; adjusted getUserByAccount calls. |
| lib/client/dbinterfaces/LocalStorageDbInterface.ts | Added new DbInterface methods wrapping super calls. |
| lib/client/dbinterfaces/InMemoryDbInterface.ts | Added new DbInterface methods wrapping super calls. |
| lib/client/dbinterfaces/DbInterface.ts | Extended interface definitions with new methods. |
| lib/client/dbinterfaces/CachedDbInterface.ts | Added new DbInterface methods wrapping super calls. |
| lib/Utils.ts | Included emailVerified in user field population. |
| lib/Types.ts | Added emailVerified property to the User type. |
| lib/Auth.ts | Removed custom profile functions for Google and Slack providers to conform to the Mongo adapter. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
tests/unit/lib/DbInterfaceAuthAdapter.test.ts:266
- [nitpick] Consider clarifying or removing the comment about 'id' behavior to ensure consistent expectations in test assertions.
// Not sure how id behaves, don't use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.