MacOS development: add a setting to override virtiofs paths#489
Draft
MacOS development: add a setting to override virtiofs paths#489
Conversation
On macOS with Docker / virtiofs, /proc/pid/maps exposes host paths (e.g. /run/host_virtiofs/Users/.../build/...) instead of the in-container path (/app/build/...). Add DDPROF_WORKSPACE_ROOT env variable support to remap these paths so libdwfl can locate ELF files. The launch_local_build.sh script sets this variable automatically on macOS.
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
r1viollet
commented
Feb 12, 2026
| void DsoHdr::init_workspace_remap() { | ||
| _workspace_host_prefix.clear(); | ||
| _workspace_container_root.clear(); | ||
| if (const char *workspace_env = std::getenv("DDPROF_WORKSPACE_ROOT"); |
Collaborator
Author
There was a problem hiding this comment.
todo: naming needs to be adjusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a setting to override file paths.
Motivation
This makes it easier to develop inside docker on macos.
Use the following
Additional Notes
NA
How to test the change?
On MacOS inside docker.