-
Notifications
You must be signed in to change notification settings - Fork 477
chore(tracer): migrate Span.{start_ns,duration_ns,error} to SpanData struct #16288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: brettlangdon/span.macros
Are you sure you want to change the base?
chore(tracer): migrate Span.{start_ns,duration_ns,error} to SpanData struct #16288
Conversation
Codeowners resolved as |
|
fec287d to
db554ec
Compare
Performance SLOsComparing candidate APMLP-941/move.start_ns.duration_ns.error (db554ec) with baseline brettlangdon/span.macros (99e34f8) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 104.282µs (SLO: <130.000µs 📉 -19.8%) vs baseline: +1.8% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 102.467µs (SLO: <130.000µs 📉 -21.2%) vs baseline: -0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 28.291µs (SLO: <40.000µs 📉 -29.3%) vs baseline: +0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 48.710µs (SLO: <70.000µs 📉 -30.4%) vs baseline: -0.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 250.730µs (SLO: <400.000µs 📉 -37.3%) vs baseline: -0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 637.199µs (SLO: <800.000µs 📉 -20.4%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 267.094µs (SLO: <400.000µs 📉 -33.2%) vs baseline: +1.0% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 141.373µs (SLO: <300.000µs 📉 -52.9%) vs baseline: +1.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 216.880µs (SLO: <300.000µs 📉 -27.7%) vs baseline: -1.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 135.370µs (SLO: <200.000µs 📉 -32.3%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 3.858ms (SLO: <5.000ms 📉 -22.8%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 316.840µs (SLO: <420.000µs 📉 -24.6%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 89.527µs (SLO: <300.000µs 📉 -70.2%) vs baseline: +2.0% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 255.333µs (SLO: <300.000µs 📉 -14.9%) vs baseline: +0.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 92.903µs (SLO: <500.000µs 📉 -81.4%) vs baseline: +4.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 309.555µs (SLO: <500.000µs 📉 -38.1%) vs baseline: +0.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 88.762µs (SLO: <100.000µs 📉 -11.2%) vs baseline: +2.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 152.573µs (SLO: <210.000µs 📉 -27.3%) vs baseline: +0.1% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 85.193µs (SLO: <200.000µs 📉 -57.4%) vs baseline: +0.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.4% ✅ encode_noaspectTime: ✅ 141.411µs (SLO: <200.000µs 📉 -29.3%) vs baseline: +1.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ format_aspectTime: ✅ 14.636ms (SLO: <19.200ms 📉 -23.8%) vs baseline: -0.5% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ format_map_aspectTime: ✅ 16.412ms (SLO: <21.500ms 📉 -23.7%) vs baseline: -0.3% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.2% ✅ format_map_noaspectTime: ✅ 374.542µs (SLO: <500.000µs 📉 -25.1%) vs baseline: +1.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 307.163µs (SLO: <500.000µs 📉 -38.6%) vs baseline: +1.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 120.100µs (SLO: <300.000µs 📉 -60.0%) vs baseline: -2.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.364µs (SLO: <300.000µs 📉 -86.5%) vs baseline: +0.7% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 215.957µs (SLO: <300.000µs 📉 -28.0%) vs baseline: -1.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 145.585µs (SLO: <300.000µs 📉 -51.5%) vs baseline: +0.7% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 493.468µs (SLO: <700.000µs 📉 -29.5%) vs baseline: -1.2% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 254.984µs (SLO: <300.000µs 📉 -15.0%) vs baseline: +1.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 294.815µs (SLO: <500.000µs 📉 -41.0%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 232.183µs (SLO: <300.000µs 📉 -22.6%) vs baseline: +0.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 0.337ms (SLO: <3.000ms 📉 -88.8%) vs baseline: 📈 +21.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.5% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 14.324ms (SLO: <18.750ms 📉 -23.6%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.855ms (SLO: <19.350ms 📉 -23.2%) vs baseline: +0.3% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 14.471ms (SLO: <18.900ms 📉 -23.4%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.659ms (SLO: <19.150ms 📉 -23.5%) vs baseline: -0.2% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.362ms (SLO: <3.000ms 📉 -87.9%) vs baseline: +1.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 19.040ms (SLO: <24.000ms 📉 -20.7%) vs baseline: +3.1% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 283.989µs (SLO: <300.000µs -5.3%) vs baseline: +0.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 320.421µs (SLO: <420.000µs 📉 -23.7%) vs baseline: +0.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 46.834µs (SLO: <90.000µs 📉 -48.0%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 395.309µs (SLO: <500.000µs 📉 -20.9%) vs baseline: +0.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ rstrip_noaspectTime: ✅ 182.061µs (SLO: <300.000µs 📉 -39.3%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 181.670µs (SLO: <300.000µs 📉 -39.4%) vs baseline: -2.9% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 53.561µs (SLO: <90.000µs 📉 -40.5%) vs baseline: -1.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 3.912ms (SLO: <5.000ms 📉 -21.8%) vs baseline: -0.3% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ stringio_noaspectTime: ✅ 350.599µs (SLO: <500.000µs 📉 -29.9%) vs baseline: +1.0% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 276.851µs (SLO: <350.000µs 📉 -20.9%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 177.682µs (SLO: <240.000µs 📉 -26.0%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 340.072µs (SLO: <500.000µs 📉 -32.0%) vs baseline: +1.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 277.516µs (SLO: <400.000µs 📉 -30.6%) vs baseline: +1.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 325.036µs (SLO: <500.000µs 📉 -35.0%) vs baseline: +0.1% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.1% ✅ title_noaspectTime: ✅ 257.742µs (SLO: <400.000µs 📉 -35.6%) vs baseline: -0.1% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 531.203µs (SLO: <700.000µs 📉 -24.1%) vs baseline: +8.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 417.241µs (SLO: <500.000µs 📉 -16.6%) vs baseline: -0.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 293.704µs (SLO: <500.000µs 📉 -41.3%) vs baseline: -0.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 235.697µs (SLO: <400.000µs 📉 -41.1%) vs baseline: +1.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 483.639µs (SLO: <700.000µs 📉 -30.9%) vs baseline: 📈 +13.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.7% ✅ ospathbasename_noaspectTime: ✅ 431.999µs (SLO: <700.000µs 📉 -38.3%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.6% ✅ ospathjoin_aspectTime: ✅ 613.203µs (SLO: <700.000µs 📉 -12.4%) vs baseline: -1.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 623.756µs (SLO: <700.000µs 📉 -10.9%) vs baseline: -1.0% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +6.2% ✅ ospathnormcase_aspectTime: ✅ 351.442µs (SLO: <700.000µs 📉 -49.8%) vs baseline: -1.1% Memory: ✅ 42.684MB (SLO: <46.000MB -7.2%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 362.187µs (SLO: <700.000µs 📉 -48.3%) vs baseline: -1.0% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.4% ✅ ospathsplit_aspectTime: ✅ 489.975µs (SLO: <700.000µs 📉 -30.0%) vs baseline: -0.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.8% ✅ ospathsplit_noaspectTime: ✅ 496.772µs (SLO: <700.000µs 📉 -29.0%) vs baseline: -1.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.5% ✅ ospathsplitdrive_aspectTime: ✅ 371.481µs (SLO: <700.000µs 📉 -46.9%) vs baseline: -1.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.5% ✅ ospathsplitdrive_noaspectTime: ✅ 73.075µs (SLO: <700.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.6% ✅ ospathsplitext_aspectTime: ✅ 457.809µs (SLO: <700.000µs 📉 -34.6%) vs baseline: -1.0% Memory: ✅ 42.762MB (SLO: <46.000MB -7.0%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 470.247µs (SLO: <700.000µs 📉 -32.8%) vs baseline: +0.9% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.350µs (SLO: <20.000µs 📉 -83.3%) vs baseline: 📈 +16.2% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.7% ✅ 1-count-metrics-100-timesTime: ✅ 198.499µs (SLO: <220.000µs -9.8%) vs baseline: -0.2% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +6.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.203µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +0.9% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.941µs (SLO: <230.000µs -7.4%) vs baseline: -0.3% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.191µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.7% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +5.4% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.882µs (SLO: <150.000µs -9.4%) vs baseline: -1.6% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +6.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.010µs (SLO: <20.000µs 📉 -84.9%) vs baseline: -0.5% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.528µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +1.4% Memory: ✅ 35.566MB (SLO: <38.000MB -6.4%) vs baseline: +5.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.402ms (SLO: <22.000ms -7.3%) vs baseline: +1.8% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +4.5% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.277ms (SLO: <2.550ms 📉 -10.7%) vs baseline: +2.8% Memory: ✅ 35.488MB (SLO: <38.000MB -6.6%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.422ms (SLO: <1.550ms -8.3%) vs baseline: +2.1% Memory: ✅ 35.468MB (SLO: <38.000MB -6.7%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.207ms (SLO: <2.550ms 📉 -13.4%) vs baseline: +0.7% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.431µs (SLO: <20.000µs 📉 -77.8%) vs baseline: -0.5% Memory: ✅ 35.586MB (SLO: <38.000MB -6.4%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.070µs (SLO: <250.000µs 📉 -30.8%) vs baseline: ~same Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.174ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -1.0% Memory: ✅ 36.372MB (SLO: <38.750MB -6.1%) vs baseline: +4.7% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.352ms (SLO: <32.950ms -4.8%) vs baseline: +0.2% Memory: ✅ 36.825MB (SLO: <39.250MB -6.2%) vs baseline: +6.0% ✅ mediumTime: ✅ 3.111ms (SLO: <3.200ms -2.8%) vs baseline: +0.5% Memory: ✅ 35.193MB (SLO: <38.750MB -9.2%) vs baseline: +4.7% ✅ smallTime: ✅ 363.106µs (SLO: <370.000µs 🟡 -1.9%) vs baseline: +4.7% Memory: ✅ 35.232MB (SLO: <38.750MB -9.1%) vs baseline: +5.0%
|
Description
Continuing our migration of attributes from the Span Python class to the native SpanData class.
This change moves over basic numeric properties,
start_ns,duration_ns, anderror.Notes:
SpanData.__new__to ensure the signature matchesSpan.__init__exactly.Time.time_nsfor the default clock to nativeSystemTime::UNIX_EPOCH.elapsed()duration_ns: Optional[int], inSpanDatawe use-1as a sentinel value of "not set"startanddurationproperties to Rust as wellstart_ns/duration_nsvalue first before dividingTesting
Risks
Additional Notes