Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 30, 2026

Description

This PR implements this RFC for Profiling by adding a process tags field to the Uploader from the tracer.

Note that if process_tags are deactivated, the value passed to the profiler will be an empty string.

Here are an example in datadog:
image
(see entrypoint.basedir/entrypoint.name fields)

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@dubloom dubloom force-pushed the dubloom/process-tags-profiling branch from aabd543 to 427e20d Compare January 30, 2026 14:01
@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-30 18:10:06

Comparing candidate commit d12de78 in PR branch dubloom/process-tags-profiling with baseline commit ff8f987 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 5 unstable metrics.

scenario:php-profiler-exceptions-with-profiler-and-timeline

  • 🟩 cpu_user_time [-6.824ms; -1.674ms] or [-8.881%; -2.179%]

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-30 18:51:46

Comparing candidate commit d12de78 in PR branch dubloom/process-tags-profiling with baseline commit ff8f987 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 186 metrics, 4 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.209µs; +4.191µs] or [+3.094%; +4.041%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+45.076ns; +110.924ns] or [+3.846%; +9.465%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+63.989ns; +124.811ns] or [+5.509%; +10.746%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+56.010ns; +130.790ns] or [+4.733%; +11.051%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 30, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1026 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 697cf25500000000bbac76e98f77e2ce
tid: 697cf25500000000
hexProcessTraceId: bbac76e98f77e2ce
hexProcessSpanId: 10557b48cd069aff
processTraceId: 13523314526593213134
processSpanId: 1176982430234876671
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d12de78 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (ff8f987) to head (d12de78).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
- Coverage   62.24%   62.20%   -0.05%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8333     8327       -6     
- Misses       4257     4263       +6     
  Partials      797      797              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8f987...d12de78. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubloom dubloom marked this pull request as ready for review January 30, 2026 17:55
@dubloom dubloom requested review from a team as code owners January 30, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants