Skip to content

Conversation

@cataphract
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested review from a team as code owners January 24, 2026 00:18
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 24, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6977b7f00000000059d24f4d38541a32
tid: 6977b7f000000000
hexProcessTraceId: 59d24f4d38541a32
hexProcessSpanId: a018629326067442
processTraceId: 6472322807560935986
processSpanId: 11536078829647197250

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

    testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 55bbeba | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.00%. Comparing base (2f81b3a) to head (55bbeba).
⚠️ Report is 2 commits behind head on bob/prof-flf-test.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           bob/prof-flf-test    #3600   +/-   ##
==================================================
  Coverage              62.00%   62.00%           
==================================================
  Files                    140      140           
  Lines                  13312    13312           
  Branches                1762     1762           
==================================================
  Hits                    8254     8254           
  Misses                  4270     4270           
  Partials                 788      788           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f81b3a...55bbeba. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-26 18:57:00

Comparing candidate commit 55bbeba in PR branch glopes/prof-flp-test with baseline commit 2f81b3a in branch bob/prof-flf-test.

Found 2 performance improvements and 3 performance regressions! Performance is the same for 23 metrics, 8 unstable metrics.

scenario:php-profiler-timeline-memory-control

  • 🟥 cpu_user_time [+35.056ms; +42.158ms] or [+5.723%; +6.883%]
  • 🟥 execution_time [+35.118ms; +42.512ms] or [+5.497%; +6.655%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 execution_time [+37.242ms; +48.422ms] or [+4.019%; +5.226%]

scenario:walk_stack/50

  • 🟩 wall_time [-995.828ns; -986.964ns] or [-6.061%; -6.007%]

scenario:walk_stack/99

  • 🟩 wall_time [-958.616ns; -954.093ns] or [-5.845%; -5.817%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants