-
Notifications
You must be signed in to change notification settings - Fork 167
Add helper rewrite in rust #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (49.72%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #3581 +/- ##
===========================================
- Coverage 62.02% 49.72% -12.30%
===========================================
Files 140 21 -119
Lines 13309 4241 -9068
Branches 1762 0 -1762
===========================================
- Hits 8255 2109 -6146
+ Misses 4265 2132 -2133
+ Partials 789 0 -789
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 140 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f4914c3 to
2fc2654
Compare
bbc593e to
192a4a1
Compare
Benchmarks [ appsec ]Benchmark execution time: 2026-01-28 20:08:34 Comparing candidate commit fc9100c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
Benchmarks [ tracer ]Benchmark execution time: 2026-01-28 22:06:48 Comparing candidate commit fc9100c in PR branch Found 2 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:EmptyFileBench/benchEmptyFileDdprof
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:PHPRedisBench/benchRedisOverhead
|
fb4432d to
8d1029e
Compare
|
This PR is so large that github will only permit me to review it one file at a time. I didn't even know that was a thing! You're going to need to break it down into a series of smaller PRs, probably. |
a218cd6 to
332fd93
Compare
|
@morrisonlevi I've had success for very big PRs with the PHPStorm/CLion github integrations in the past. Doesn't matter for small PRs, but can definitely recommend it for extra-large PRs :-) |
Changes the request_exec message format from [rasp_rule, data] to [data, options_map]. The options map supports: - rasp_rule: string (same as before) - subctx_id: optional string (accepted but ignored) - subctx_last_call: optional bool (accepted but ignored) This prepares the protocol for curl/subcontext support while maintaining backwards compatibility. The subcontext fields are accepted by the protocol but not implemented in the business logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Upgrade testcontainers - Add some assertions - Better debug output for metrics
fc9100c to
718f800
Compare
Description
Passing integration and system-tests.
Further integration into sidecar and protocol changes pending.
Reviewer checklist