-
Notifications
You must be signed in to change notification settings - Fork 324
Fix debugger start when endpoints aren't available #10401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.623 µs) : 280, 355
. : milestone, 318,
basic (272.234 µs) : 267, 278
. : milestone, 272,
loop (8.94 ms) : 8935, 8946
. : milestone, 8940,
section candidate
noprobe (303.222 µs) : 279, 328
. : milestone, 303,
basic (271.188 µs) : 265, 278
. : milestone, 271,
loop (8.954 ms) : 8948, 8960
. : milestone, 8954,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091710
Total [baseline] (8.798 s) : 0, 8797668
Agent [candidate] (1.088 s) : 0, 1087823
Total [candidate] (8.785 s) : 0, 8784814
section iast
Agent [baseline] (1.223 s) : 0, 1222891
Total [baseline] (9.356 s) : 0, 9355879
Agent [candidate] (1.229 s) : 0, 1229064
Total [candidate] (9.388 s) : 0, 9387533
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (656.701 ms) : 0, 656701
BytebuddyAgent [candidate] (653.308 ms) : 0, 653308
GlobalTracer [baseline] (284.552 ms) : 0, 284552
GlobalTracer [candidate] (284.314 ms) : 0, 284314
AppSec [baseline] (32.865 ms) : 0, 32865
AppSec [candidate] (32.826 ms) : 0, 32826
Debugger [baseline] (67.237 ms) : 0, 67237
Debugger [candidate] (67.372 ms) : 0, 67372
Remote Config [baseline] (638.455 µs) : 0, 638
Remote Config [candidate] (639.548 µs) : 0, 640
Telemetry [baseline] (9.013 ms) : 0, 9013
Telemetry [candidate] (8.921 ms) : 0, 8921
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.797 ms) : 0, 3797
section iast
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (790.965 ms) : 0, 790965
BytebuddyAgent [candidate] (795.203 ms) : 0, 795203
GlobalTracer [baseline] (256.956 ms) : 0, 256956
GlobalTracer [candidate] (258.449 ms) : 0, 258449
AppSec [baseline] (34.06 ms) : 0, 34060
AppSec [candidate] (34.346 ms) : 0, 34346
Debugger [baseline] (64.818 ms) : 0, 64818
Debugger [candidate] (64.819 ms) : 0, 64819
Remote Config [baseline] (568.44 µs) : 0, 568
Remote Config [candidate] (580.16 µs) : 0, 580
Telemetry [baseline] (8.443 ms) : 0, 8443
Telemetry [candidate] (8.523 ms) : 0, 8523
Flare Poller [baseline] (3.591 ms) : 0, 3591
Flare Poller [candidate] (3.569 ms) : 0, 3569
IAST [baseline] (26.935 ms) : 0, 26935
IAST [candidate] (27.066 ms) : 0, 27066
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085543
Total [baseline] (10.727 s) : 0, 10727415
Agent [candidate] (1.093 s) : 0, 1092545
Total [candidate] (10.822 s) : 0, 10822087
section appsec
Agent [baseline] (1.275 s) : 0, 1274555
Total [baseline] (11.045 s) : 0, 11045453
Agent [candidate] (1.264 s) : 0, 1264462
Total [candidate] (11.063 s) : 0, 11062624
section iast
Agent [baseline] (1.232 s) : 0, 1231724
Total [baseline] (11.177 s) : 0, 11177375
Agent [candidate] (1.228 s) : 0, 1227604
Total [candidate] (11.238 s) : 0, 11238114
section profiling
Agent [baseline] (1.206 s) : 0, 1205641
Total [baseline] (10.858 s) : 0, 10857713
Agent [candidate] (1.205 s) : 0, 1205311
Total [candidate] (10.95 s) : 0, 10949764
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (651.952 ms) : 0, 651952
BytebuddyAgent [candidate] (656.093 ms) : 0, 656093
GlobalTracer [baseline] (283.08 ms) : 0, 283080
GlobalTracer [candidate] (284.496 ms) : 0, 284496
AppSec [baseline] (32.692 ms) : 0, 32692
AppSec [candidate] (32.912 ms) : 0, 32912
Debugger [baseline] (67.839 ms) : 0, 67839
Debugger [candidate] (68.622 ms) : 0, 68622
Remote Config [baseline] (625.586 µs) : 0, 626
Remote Config [candidate] (627.252 µs) : 0, 627
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (9.061 ms) : 0, 9061
Flare Poller [baseline] (3.819 ms) : 0, 3819
Flare Poller [candidate] (3.864 ms) : 0, 3864
section appsec
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (696.726 ms) : 0, 696726
BytebuddyAgent [candidate] (691.026 ms) : 0, 691026
GlobalTracer [baseline] (260.659 ms) : 0, 260659
GlobalTracer [candidate] (258.434 ms) : 0, 258434
AppSec [baseline] (175.139 ms) : 0, 175139
AppSec [candidate] (172.987 ms) : 0, 172987
Debugger [baseline] (66.516 ms) : 0, 66516
Debugger [candidate] (66.918 ms) : 0, 66918
Remote Config [baseline] (743.907 µs) : 0, 744
Remote Config [candidate] (760.54 µs) : 0, 761
Telemetry [baseline] (9.333 ms) : 0, 9333
Telemetry [candidate] (9.47 ms) : 0, 9470
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.737 ms) : 0, 3737
IAST [baseline] (24.879 ms) : 0, 24879
IAST [candidate] (24.519 ms) : 0, 24519
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (795.21 ms) : 0, 795210
BytebuddyAgent [candidate] (793.288 ms) : 0, 793288
GlobalTracer [baseline] (258.56 ms) : 0, 258560
GlobalTracer [candidate] (257.2 ms) : 0, 257200
AppSec [baseline] (33.968 ms) : 0, 33968
AppSec [candidate] (34.402 ms) : 0, 34402
Debugger [baseline] (67.458 ms) : 0, 67458
Debugger [candidate] (66.443 ms) : 0, 66443
Remote Config [baseline] (574.998 µs) : 0, 575
Remote Config [candidate] (550.351 µs) : 0, 550
Telemetry [baseline] (8.532 ms) : 0, 8532
Telemetry [candidate] (8.47 ms) : 0, 8470
Flare Poller [baseline] (3.592 ms) : 0, 3592
Flare Poller [candidate] (3.563 ms) : 0, 3563
IAST [baseline] (27.22 ms) : 0, 27220
IAST [candidate] (27.114 ms) : 0, 27114
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (703.138 ms) : 0, 703138
BytebuddyAgent [candidate] (701.687 ms) : 0, 701687
GlobalTracer [baseline] (221.409 ms) : 0, 221409
GlobalTracer [candidate] (221.099 ms) : 0, 221099
AppSec [baseline] (32.041 ms) : 0, 32041
AppSec [candidate] (32.206 ms) : 0, 32206
Debugger [baseline] (68.034 ms) : 0, 68034
Debugger [candidate] (68.063 ms) : 0, 68063
Remote Config [baseline] (651.702 µs) : 0, 652
Remote Config [candidate] (639.634 µs) : 0, 640
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (8.964 ms) : 0, 8964
Flare Poller [baseline] (3.703 ms) : 0, 3703
Flare Poller [candidate] (3.843 ms) : 0, 3843
ProfilingAgent [baseline] (96.772 ms) : 0, 96772
ProfilingAgent [candidate] (97.904 ms) : 0, 97904
Profiling [baseline] (97.358 ms) : 0, 97358
Profiling [candidate] (98.485 ms) : 0, 98485
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.19 ms) : 3152, 3228
. : milestone, 3190,
iast_FULL (5.903 ms) : 5843, 5962
. : milestone, 5903,
iast_GLOBAL (3.691 ms) : 3637, 3746
. : milestone, 3691,
profiling (2.164 ms) : 2144, 2185
. : milestone, 2164,
tracing (1.787 ms) : 1772, 1802
. : milestone, 1787,
section candidate
no_agent (1.19 ms) : 1179, 1202
. : milestone, 1190,
iast (3.149 ms) : 3111, 3187
. : milestone, 3149,
iast_FULL (5.82 ms) : 5762, 5878
. : milestone, 5820,
iast_GLOBAL (3.675 ms) : 3617, 3733
. : milestone, 3675,
profiling (2.25 ms) : 2229, 2270
. : milestone, 2250,
tracing (1.831 ms) : 1813, 1849
. : milestone, 1831,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (18.031 ms) : 17846, 18216
. : milestone, 18031,
appsec (18.377 ms) : 18194, 18560
. : milestone, 18377,
code_origins (17.574 ms) : 17402, 17746
. : milestone, 17574,
iast (18.78 ms) : 18591, 18970
. : milestone, 18780,
profiling (18.392 ms) : 18213, 18571
. : milestone, 18392,
tracing (17.731 ms) : 17554, 17908
. : milestone, 17731,
section candidate
no_agent (18.11 ms) : 17928, 18291
. : milestone, 18110,
appsec (18.473 ms) : 18286, 18660
. : milestone, 18473,
code_origins (17.885 ms) : 17708, 18062
. : milestone, 17885,
iast (17.365 ms) : 17194, 17536
. : milestone, 17365,
profiling (19.467 ms) : 19272, 19661
. : milestone, 19467,
tracing (17.962 ms) : 17782, 18142
. : milestone, 17962,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
appsec (14.682 s) : 14682000, 14682000
. : milestone, 14682000,
iast (17.903 s) : 17903000, 17903000
. : milestone, 17903000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
. : milestone, 18020000,
profiling (14.591 s) : 14591000, 14591000
. : milestone, 14591000,
tracing (14.761 s) : 14761000, 14761000
. : milestone, 14761000,
section candidate
no_agent (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
appsec (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
iast (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
iast_GLOBAL (17.832 s) : 17832000, 17832000
. : milestone, 17832000,
profiling (15.686 s) : 15686000, 15686000
. : milestone, 15686000,
tracing (14.505 s) : 14505000, 14505000
. : milestone, 14505000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~9b6c200b3b, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.747 ms) : 3529, 3965
. : milestone, 3747,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.259 ms) : 2193, 2324
. : milestone, 2259,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.047 ms) : 1996, 2099
. : milestone, 2047,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.656 ms) : 3443, 3869
. : milestone, 3656,
iast (2.224 ms) : 2159, 2290
. : milestone, 2224,
iast_GLOBAL (2.248 ms) : 2183, 2314
. : milestone, 2248,
profiling (2.095 ms) : 2041, 2150
. : milestone, 2095,
tracing (2.043 ms) : 1992, 2095
. : milestone, 2043,
|
catch exception throws during common init and keep the product stopped SymDB, Exception Replay and Code Origin requires CommonInit which may in some cases throw exception (endpoints are not available from Datadog Agent)
6e5afe4 to
9b6c200
Compare
What Does This Do
catch exception throws during common init and keep the product stopped SymDB, Exception Replay and Code Origin requires CommonInit which may in some cases throw exception (endpoints are not available from Datadog Agent)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4985