👷 skip BrowserStack tests for non-code changes #4136
Draft
+64
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip unit-bs and e2e-bs jobs when changes only affect files that don't impact browser behavior (CI config, scripts, docs, etc.). This saves BrowserStack resources (limited to 5 seats) and reduces pipeline duration for PRs that only touch infrastructure files. Jobs will still run when changes affect: - packages/**/* (SDK source code) - test/**/* (test files) - developer-extension/**/* (devtools extension) - package.json, yarn.lock (dependencies) - tsconfig*.json, webpack.base.ts (build config)
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: a7e4852 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory PerformancePending... |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 531d8a8953
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add scripts/test/**/* to the changes list so that modifications to BrowserStack runner scripts (like ci-bs.sh) trigger the BS jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
unit-bsande2e-bsjobs use BrowserStack resources which are limited to 5 seats. These jobs are slow and consume resources even when PRs don't touch code that affects browser behavior (e.g., CI config changes, script updates, documentation).Changes
ci-bs.shto TypeScript (ci-bs.ts) for consistency with other scriptspackages/**(SDK source code)test/**(test files and infrastructure)developer-extension/**(devtools extension)scripts/test/**(test scripts)package.json,yarn.lock(dependencies)tsconfig*,webpack.base.ts(build config)If no relevant files changed, the script exits early without running BrowserStack tests.
Test instructions
packages/triggers the BS jobs normallyChecklist