Fix test_explicit in test_aggregates#473
Open
KhaledTo wants to merge 1 commit intoDataBrewery:masterfrom
Open
Conversation
KhaledTo
changed the title
KhaledTo
force-pushed
the
fix_test_explicit
branch
from
fd614f5 to
be15358
Compare
Contributor
Author
|
We also need to remove raise NotImplementedError("Depreciated in this context") Line 54 in 140133e But before that I need to understand why this exception is raised there. Can someone explain me that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_explicit was failing because
amount_sumaggregate was missing fromdefautcube.